-
Notifications
You must be signed in to change notification settings - Fork 13.6k
libtest: print the type of test being run #144596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
libtest: print the type of test being run #144596
Conversation
r? @notriddle rustbot has assigned @notriddle. Use |
This comment has been minimized.
This comment has been minimized.
8268d87
to
09cc526
Compare
This comment has been minimized.
This comment has been minimized.
09cc526
to
cad8dec
Compare
This comment has been minimized.
This comment has been minimized.
cad8dec
to
7b2f5cb
Compare
This comment has been minimized.
This comment has been minimized.
7b2f5cb
to
eb94731
Compare
This comment has been minimized.
This comment has been minimized.
eb94731
to
1375aad
Compare
This comment has been minimized.
This comment has been minimized.
1375aad
to
be14f03
Compare
This comment has been minimized.
This comment has been minimized.
be14f03
to
fbcaaba
Compare
it is very annoying to have to manually bless all the the tests that don't run on x86 linux. |
This comment has been minimized.
This comment has been minimized.
fbcaaba
to
a86449f
Compare
This comment has been minimized.
This comment has been minimized.
a86449f
to
a1e04a0
Compare
This comment has been minimized.
This comment has been minimized.
a1e04a0
to
7c96984
Compare
This PR modifies cc @jieyouxu |
@GuillaumeGomez ok, got all the tests passing, should be ready for code review now |
This changes libtest output, so cc @rust-lang/testing-devex |
Changes look good to me, thanks! Gonna wait for devex to confirm it's good for them as well before r+. |
The bar is pretty low since this is human output and there are no compatibility guarantees As part of our work to stabilize the json output, we'll be wanting I suspect even libtest's output may change in the shuffle related to json output which would put this at risk. If you feel this is important enough, I'd recommend engaging on assert-rs/libtest2#42. Note that this feels very coupled to the specific situations and would likely not be good to include in the json as-is. If people are ok with the risk this gets reverted, I'm not seeing a reason within testing-devex to block this. Considering the lack of guarantees, we don't need an FCP. |
☔ The latest upstream changes (presumably #144692) made this pull request unmergeable. Please resolve the merge conflicts. |
7c96984
to
a6d1842
Compare
supplemental to #144308
unfortunately because stage1 rustdoc is checked in CI, we need to use
cfg(bootstrap)
for the transitional period.cc @GuillaumeGomez