Skip to content

libtest: print the type of test being run #144596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lolbinarycat
Copy link
Contributor

@lolbinarycat lolbinarycat commented Jul 28, 2025

supplemental to #144308

unfortunately because stage1 rustdoc is checked in CI, we need to use cfg(bootstrap) for the transitional period.

cc @GuillaumeGomez

@rustbot
Copy link
Collaborator

rustbot commented Jul 28, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 28, 2025
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the libtest-print-doctest-type branch 2 times, most recently from 8268d87 to 09cc526 Compare July 28, 2025 18:30
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat marked this pull request as draft July 28, 2025 18:40
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2025
@lolbinarycat lolbinarycat force-pushed the libtest-print-doctest-type branch from 09cc526 to cad8dec Compare July 28, 2025 18:57
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the libtest-print-doctest-type branch from cad8dec to 7b2f5cb Compare July 28, 2025 19:33
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the libtest-print-doctest-type branch from 7b2f5cb to eb94731 Compare July 28, 2025 20:21
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the libtest-print-doctest-type branch from eb94731 to 1375aad Compare July 28, 2025 20:29
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the libtest-print-doctest-type branch from 1375aad to be14f03 Compare July 28, 2025 21:37
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the libtest-print-doctest-type branch from be14f03 to fbcaaba Compare July 29, 2025 01:54
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Jul 29, 2025
@lolbinarycat
Copy link
Contributor Author

it is very annoying to have to manually bless all the the tests that don't run on x86 linux.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the libtest-print-doctest-type branch from a86449f to a1e04a0 Compare July 29, 2025 19:47
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the libtest-print-doctest-type branch from a1e04a0 to 7c96984 Compare July 29, 2025 21:19
@lolbinarycat lolbinarycat marked this pull request as ready for review July 29, 2025 22:33
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2025

This PR modifies run-make tests.

cc @jieyouxu

@lolbinarycat
Copy link
Contributor Author

@GuillaumeGomez ok, got all the tests passing, should be ready for code review now

@jieyouxu
Copy link
Member

This changes libtest output, so cc @rust-lang/testing-devex

@jieyouxu jieyouxu added the A-libtest Area: `#[test]` / the `test` library label Jul 30, 2025
@GuillaumeGomez
Copy link
Member

Changes look good to me, thanks! Gonna wait for devex to confirm it's good for them as well before r+.

@epage
Copy link
Contributor

epage commented Jul 30, 2025

The bar is pretty low since this is human output and there are no compatibility guarantees

As part of our work to stabilize the json output, we'll be wanting cargo test to do its own rendering, rather than using --format pretty, so the output will likely be dramatically re-imagined at that point (whether or when this affects doctest is dependent on if we are able to get rustdoc out of cargos way). Unsure how or if this will be preserved.

I suspect even libtest's output may change in the shuffle related to json output which would put this at risk.

If you feel this is important enough, I'd recommend engaging on assert-rs/libtest2#42. Note that this feels very coupled to the specific situations and would likely not be good to include in the json as-is.

If people are ok with the risk this gets reverted, I'm not seeing a reason within testing-devex to block this. Considering the lack of guarantees, we don't need an FCP.

@bors
Copy link
Collaborator

bors commented Jul 30, 2025

☔ The latest upstream changes (presumably #144692) made this pull request unmergeable. Please resolve the merge conflicts.

@lolbinarycat lolbinarycat force-pushed the libtest-print-doctest-type branch from 7c96984 to a6d1842 Compare July 31, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-libtest Area: `#[test]` / the `test` library A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants