Skip to content

avoid hangs if there are 10 billion where-clauses #144574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

avoid hangs if there are 10 billion where-clauses #144574

wants to merge 2 commits into from
+81 −7

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jul 28, 2025

r? ghost

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 28, 2025
@lcnr
Copy link
Contributor Author

lcnr commented Jul 28, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Jul 28, 2025

⌛ Trying commit 8f380a2 with merge 542bc31…

To cancel the try build, run the command @bors try cancel.

rust-bors bot added a commit that referenced this pull request Jul 28, 2025
@rust-bors
Auto merge of #144574 - lcnr:fast-paths-avoid-impls, r=<try>
542bc31 
avoid hangs if there are 10 billion where-clauses
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 28, 2025
@rust-bors
Copy link

rust-bors bot commented Jul 28, 2025

☀️ Try build successful (CI)
Build commit: 542bc31 (542bc315e4c4c8b2caee824f1341248e334aa775, parent: d242a8bd5a73f633ba1ec5aacf19acf35a3c747d)

@rust-timer
Copy link
Collaborator

Queued 542bc31 with parent d242a8b, future comparison URL.
There are currently 2 preceding artifacts in the queue.
It will probably take at least ~2.3 hours until the benchmark run finishes.

@bors
Copy link
Collaborator

bors commented Jul 31, 2025

☔ The latest upstream changes (presumably #144405) made this pull request unmergeable. Please resolve the merge conflicts.

@lcnr lcnr force-pushed the fast-paths-avoid-impls branch from 8f380a2 to 64ba6ba Compare July 31, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcnr @rust-timer @bors @rustbot