Add --print target-spec-json-schema #144498
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
With this macro we only need to enumerate every variant once. This saves a lot of duplication already between the definition, the `FromStr` impl and the `ToJson` impl. It also enables us to do further things with it like JSON schema generation.
Noratrieb
force-pushed
the
rustc-json-schema
branch
from
547cba8 to
d6acb28
Compare
rustbot
added
A-tidy
This comment has been minimized.
This comment has been minimized.
Noratrieb
force-pushed
the
rustc-json-schema
branch
from
d6acb28 to
8f1abd3
Compare
This comment has been minimized.
This comment has been minimized.
Noratrieb
force-pushed
the
rustc-json-schema
branch
from
8f1abd3 to
a07cfd1
Compare
This comment has been minimized.
This comment has been minimized.
This schema is helpful for people writing custom target spec JSON. It can provide autocomplete in the editor, and also serves as documentation when there are documentation comments on the structs, as `schemars` will put them in the schema.
Noratrieb
force-pushed
the
rustc-json-schema
branch
from
a07cfd1 to
d4383c1
Compare
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_ssa The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. These commits modify the If this was unintentional then you should revert the changes before this PR is merged. These commits modify compiler targets. This PR modifies cc @jieyouxu There are changes to the cc @jieyouxu |
|
The MCP isn't accepted yet, but that doesn't need to stop anyone from reviewing. |
|
|
|
I can probably review it after the MCP passes. |
| fn json_schema(_: &mut schemars::SchemaGenerator) -> schemars::Schema { | ||
| schemars::json_schema! ({ | ||
| "type": "string", | ||
| "enum": ["false", "true", "wasm", "musl", "mingw"] |
There was a problem hiding this comment.
Question: for some options, it seems like there are no target_spec_enum-like help where the possible variants are sync'd. Not that I think this is a big problem, just some extra potential for desync.
| schemars::json_schema! ({ | ||
| "type": "string", | ||
| }) |
There was a problem hiding this comment.
Question: is this because it's annoying if not impossible to express an array of:
- "Simple strings" like
noneordefault-for-arch, vs - "Key-value strings" like
llvm-module-flag=xxxorllvm-arg=xxx, right?
| @@ -361,6 +362,8 @@ const PERMITTED_RUSTC_DEPENDENCIES: &[&str] = &[ | |||
| "rand_xorshift", // dependency for doc-tests in rustc_thread_pool | |||
| "rand_xoshiro", | |||
| "redox_syscall", | |||
| "ref-cast", | |||
There was a problem hiding this comment.
Remark: at least this uses rustc version detection, not just nightly detection
|
None of them are blocking, so feel free to r=me once the MCP is accepted. |
jieyouxu
added
S-waiting-on-MCP
This schema is helpful for people writing custom target spec JSON. It can provide autocomplete in the editor, and also serves as documentation when there are documentation comments on the structs, as
schemarswill put them in the schema.I was motivated to do this because I saw someone write their own version of this schema by hand, so demand for this clearly exists. It's not a lot of effort to implement, so I thought it would make sense.
MCP: rust-lang/compiler-team#905
I think it would also be useful to put this in the sysroot in
etcso people can link it directly in their editors.I would have loved to add a test that validates the JSON schema against the spec JSON of every builtin target, but I don't want to do it as the JSON schema validation crates have incredible amounts of dependencies because JSON schema supports a ton of random features. I don't want to add that, even as a dev dependency.