Skip to content

Make libtest::ERROR_EXIT_CODE const public to not redefine it in rustdoc #144297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GuillaumeGomez
Copy link
Member

I think it's better to make this constant public so it can be used by crates using libtest as dependency.

As a side-note, I will update #143900 to make use of this constant once this is current PR is merged.

@rustbot
Copy link
Collaborator

rustbot commented Jul 22, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 22, 2025
@GuillaumeGomez
Copy link
Member Author

Might be better to assign someone from the libs team instead.

r? @Amanieu

@rustbot rustbot assigned Amanieu and unassigned notriddle Jul 22, 2025
@jieyouxu jieyouxu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 22, 2025
@rust-log-analyzer

This comment has been minimized.

@@ -90,7 +90,7 @@ use test_result::*;
use time::TestExecTime;

// Process exit code to be used to indicate test failures.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Process exit code to be used to indicate test failures.
/// Process exit code to be used to indicate test failures.

@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member Author

Hum... I'll remove the change in librustdoc and make it as a follow-up since it seems it cannot be done in one PR. That's a bit sad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants