-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Make libtest::ERROR_EXIT_CODE
const public to not redefine it in rustdoc
#144297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @notriddle rustbot has assigned @notriddle. Use |
Might be better to assign someone from the libs team instead. r? @Amanieu |
This comment has been minimized.
This comment has been minimized.
library/test/src/lib.rs
Outdated
@@ -90,7 +90,7 @@ use test_result::*; | |||
use time::TestExecTime; | |||
|
|||
// Process exit code to be used to indicate test failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Process exit code to be used to indicate test failures. | |
/// Process exit code to be used to indicate test failures. |
d9fe786
to
722e63a
Compare
This comment has been minimized.
This comment has been minimized.
Hum... I'll remove the change in librustdoc and make it as a follow-up since it seems it cannot be done in one PR. That's a bit sad. |
I think it's better to make this constant public so it can be used by crates using
libtest
as dependency.As a side-note, I will update #143900 to make use of this constant once this is current PR is merged.