-
Notifications
You must be signed in to change notification settings - Fork 13.4k
add issue template for rustdoc #142736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add issue template for rustdoc #142736
Conversation
|
b6920da
to
dfaa622
Compare
Seems good to me, thanks! Gonna let @fmease give the final approval. |
Thanks for your understanding and for incorporating my feedback! @bors r=GuillaumeGomez,fmease |
@bors rollup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
(These can be changed in a follow-up)
--> | ||
|
||
# Code | ||
<!-- problematic snippet and/or link to repo and/or full path of standard library function --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth trying to encourage people to submit self-contained bugs, rather than point to std
.
Obviously it's not always possible, but when it is, I think it's valuable to get an example than can be build locally.
|
||
# Version | ||
<!-- | ||
Available via `rustdoc --version` or under the "Help" menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: rustdoc --version --verbose
is worthwhile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for what info? the only extra info it really adds as far as I can see are LLVM version and host platform triple, which I haven't seen be relevant ever (am I missing something?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was mainly thinking commit hash, but checking it now that's also in plain rustdoc -V
output, so I think this is fine.
This also expands the scope of the "diagnosticissue" template to include rustdoc lints,
meaning diagnostic issues will need triaging again. I think this is preferable to the alternative of
cramming even more cases under a single issue template.
r? t-rustdoc