Skip to content

add issue template for rustdoc #142736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lolbinarycat
Copy link
Contributor

@lolbinarycat lolbinarycat commented Jun 19, 2025

This also expands the scope of the "diagnostic
issue" template to include rustdoc lints,
meaning diagnostic issues will need triaging again. I think this is preferable to the alternative of
cramming even more cases under a single issue template.

r? t-rustdoc

@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2025
@lolbinarycat lolbinarycat added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 19, 2025
@lolbinarycat
Copy link
Contributor Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned notriddle Jun 19, 2025
@lolbinarycat lolbinarycat force-pushed the rustdoc-issue-template branch from b6920da to dfaa622 Compare June 19, 2025 21:24
@GuillaumeGomez
Copy link
Member

Seems good to me, thanks!

Gonna let @fmease give the final approval.

@fmease
Copy link
Member

fmease commented Jun 19, 2025

Thanks for your understanding and for incorporating my feedback!

@bors r=GuillaumeGomez,fmease

@bors
Copy link
Collaborator

bors commented Jun 19, 2025

📌 Commit dfaa622 has been approved by GuillaumeGomez,fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2025
@fmease
Copy link
Member

fmease commented Jun 19, 2025

@bors rollup

Copy link
Member

@aDotInTheVoid aDotInTheVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

(These can be changed in a follow-up)

-->

# Code
<!-- problematic snippet and/or link to repo and/or full path of standard library function -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth trying to encourage people to submit self-contained bugs, rather than point to std.

Obviously it's not always possible, but when it is, I think it's valuable to get an example than can be build locally.


# Version
<!--
Available via `rustdoc --version` or under the "Help" menu.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: rustdoc --version --verbose is worthwhile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for what info? the only extra info it really adds as far as I can see are LLVM version and host platform triple, which I haven't seen be relevant ever (am I missing something?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mainly thinking commit hash, but checking it now that's also in plain rustdoc -V output, so I think this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants