Skip to content

Disable download-rustc on CI #142241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 9, 2025

@rustbot
Copy link
Collaborator

rustbot commented Jun 9, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 9, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jun 9, 2025

Tracking this in #142244.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, unfortunate, but I had a hard time reproducing this in a way that doesn't inhibit the failure from occurring.

@jieyouxu
Copy link
Member

jieyouxu commented Jun 9, 2025

Just to double-check, @onur-ozkan what do you think?

@onur-ozkan
Copy link
Member

IMO, it's better to actually fix the bug rather than just disabling download-rustc on CI, since part of the reason for using download-rustc in CI is to catch bugs as soon as they appear.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 9, 2025

Eventually yes, but this is now causing issues for contributors, and it's quite hard to debug (CI fails only in some circumstances).

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 9, 2025

There are various failures happening around download-ci-rustc at the moment, I would vote for just disabling it for now to unblock CI, and then we can investigate and re-enable later.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 9, 2025

@bors r=jieyouxu p=1

To unblock PRs like #138062.

@bors
Copy link
Collaborator

bors commented Jun 9, 2025

📌 Commit ee8853b has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2025
@RalfJung
Copy link
Member

RalfJung commented Jun 9, 2025

@bors p=99
this should trump the next rollup

@bors
Copy link
Collaborator

bors commented Jun 9, 2025

⌛ Testing commit ee8853b with merge 00b5262...

@bors
Copy link
Collaborator

bors commented Jun 9, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 00b5262 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 9, 2025
@bors bors merged commit 00b5262 into rust-lang:master Jun 9, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 9, 2025
Copy link
Contributor

github-actions bot commented Jun 9, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 14863ea (parent) -> 00b5262 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 00b526212bbdd68872d6f964fcc9a14a66c36fd8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-1: 6051.5s -> 7254.2s (19.9%)
  2. dist-apple-various: 6719.2s -> 7740.9s (15.2%)
  3. dist-x86_64-solaris: 5552.1s -> 5036.7s (-9.3%)
  4. dist-aarch64-msvc: 8275.4s -> 9041.2s (9.3%)
  5. dist-x86_64-netbsd: 4904.1s -> 4514.4s (-7.9%)
  6. dist-android: 2709.7s -> 2505.6s (-7.5%)
  7. i686-gnu-nopt-2: 5766.4s -> 5347.3s (-7.3%)
  8. dist-aarch64-linux: 5599.3s -> 5972.4s (6.7%)
  9. dist-x86_64-illumos: 5578.4s -> 5949.8s (6.7%)
  10. dist-arm-linux-musl: 5744.2s -> 5381.9s (-6.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (00b5262): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
4.5% [4.5%, 4.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.5% [4.5%, 4.5%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 753.531s -> 754.885s (0.18%)
Artifact size: 372.34 MiB -> 372.30 MiB (-0.01%)

@Kobzol Kobzol deleted the disable-ci-rustc-on-ci branch June 10, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants