-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Disable download-rustc on CI #142241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable download-rustc on CI #142241
Conversation
|
Tracking this in #142244. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, unfortunate, but I had a hard time reproducing this in a way that doesn't inhibit the failure from occurring.
Just to double-check, @onur-ozkan what do you think? |
IMO, it's better to actually fix the bug rather than just disabling download-rustc on CI, since part of the reason for using download-rustc in CI is to catch bugs as soon as they appear. |
Eventually yes, but this is now causing issues for contributors, and it's quite hard to debug (CI fails only in some circumstances). |
There are various failures happening around download-ci-rustc at the moment, I would vote for just disabling it for now to unblock CI, and then we can investigate and re-enable later. |
@bors p=99 |
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 14863ea (parent) -> 00b5262 (this PR) Test differencesNo test diffs found Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 00b526212bbdd68872d6f964fcc9a14a66c36fd8 --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (00b5262): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 4.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 753.531s -> 754.885s (0.18%) |
Should resolve https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/aarch64-apple.20try.20job.20doesn.27t.20work/with/522659759.
r? @jieyouxu