Fix broken-pipe-no-ice run-make test for rpath-less builds
#140843
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rare cases, the test may need access to the underlying `std::process::Command` (e.g. for non-trivial process spawning). Co-authored-by: Jesus Checa Hidalgo <[email protected]>
Where host compiler runtime libs are properly configured, instead of raw `RUSTC`/`RUSTDOC` commands. Co-authored-by: Jesus Checa Hidalgo <[email protected]>
rustbot
added
A-run-make
Kobzol
reviewed
May 9, 2025
|
Yeah I considered those options, but it seems really rare to need to implement those.
|
|
Waiting a bit to hear back from @jchecahi in case this isn't sufficient for them. Locally, the test passes for me when I set |
|
@jieyouxu yes, this approach fixes the test in my setup too. Thanks for looking into this! |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
broken-pipe-no-icerun-make test currently fails on rpath-less builds, because host compiler runtime libs are not configured for raw std command usages.This PR is an alternative approach to #140744. However, instead of duplicating
run_make_support::util::set_host_compiler_dylib_pathlogic, we instead support "ejecting" the "configured" underlying stdCommandfrombare_rustc()andrustdoc(), where host compiler runtime libs are already set.cc @jchecahi
r? @Kobzol