-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Async drop source info fix for proxy-drop-coroutine #140630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azhogin
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
azhogin:azhogin/async-drop-proxy-source-info-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Async drop source info fix for proxy-drop-coroutine #140630
azhogin
wants to merge
1
commit into
rust-lang:master
from
azhogin:azhogin/async-drop-proxy-source-info-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @nnethercote rustbot has assigned @nnethercote. Use |
r? oli-obk |
jieyouxu
reviewed
May 3, 2025
…debug info generation
7eadc69
to
a82b7a6
Compare
oli-obk
approved these changes
May 4, 2025
@bors r+ rollup |
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
May 4, 2025
…ource-info-fix, r=oli-obk Async drop source info fix for proxy-drop-coroutine Fixes crash at debug info generation: rust-lang#140426 . Also, the submitted example requires sync Drop implementation too. Because sync version is required for unwind and when drop is performed in sync context (sync function). Probably, it is also needed to add such a lint/error about missed `impl Drop`, when there is `impl AsyncDrop`. Fix description: even minimal, empty coroutine (for proxy-coroutine) has 3 states and the source info array should have 3 elements too. ``` #![feature(async_drop)] use std::future::AsyncDrop; use std::pin::Pin; #[tokio::main(flavor = "current_thread")] async fn main() { let _st = St; } struct St; impl AsyncDrop for St { async fn drop(self: Pin<&mut Self>) { println!("123"); } } ```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2025
Rollup of 3 pull requests Successful merges: - rust-lang#140357 (bypass linker configuration and cross target check on `x check`) - rust-lang#140580 (Don't name variables from external macros in borrow errors.) - rust-lang#140630 (Async drop source info fix for proxy-drop-coroutine) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
F-async_drop
`#![feature(async_drop)]`
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash at debug info generation: #140426 .
Also, the submitted example requires sync Drop implementation too.
Because sync version is required for unwind and when drop is performed in sync context (sync function).
Probably, it is also needed to add such a lint/error about missed
impl Drop
, when there isimpl AsyncDrop
.Fix description: even minimal, empty coroutine (for proxy-coroutine) has 3 states and the source info array should have 3 elements too.