Temporarily disable tests/ui/sanitizier/asan_odr_windows.rs
#140190
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fails on native windows-msvc checkout with no modifications, using a default bootstrap build config. ```text = note: LINK : fatal error LNK1104: cannot open file 'clang_rt.asan_dynamic_runtime_thunk-x86_64.lib'␍ ```
rustbot
added
PG-exploit-mitigations
|
Some changes occurred in tests/ui/sanitizer cc @rcvalle |
|
Actually, let me double check sth. |
rustbot
removed
the
S-waiting-on-review
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
jieyouxu
added
A-testsuite
|
Nah, @rustbot ready |
rustbot
added
S-waiting-on-review
|
Wait that can't be right. How does this even pass in CI? |
jieyouxu
added
S-waiting-on-author
|
Nvm, PEBKAC, cf. #140189 |
FTR, on MSVC and when LLD isn't used, we pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails on native Windows MSVC checkout with no modifications, using a default bootstrap build config.
This test being disabled is tracked by #140189.
Maybe related to #131363 (and another instance where this test failed slightly differently for me in #135013), but AFAICT I was not using
lld-link, and does not require lld to repro, default build config w/link.exealso fails.cc Sanitizers tracking issue: #39699 (that tracking issue is very confusing)
cc Sanitizers stabilization tracking issue: #123615
r? compiler