Rollup of 7 pull requests #139581

matthiaskrgr · 2025-04-09T12:52:40Z

Successful merges:

Try not to use verbatim paths in Command::current_dir #138869 (Try not to use verbatim paths in Command::current_dir)
Make cfg_match! a semitransparent macro #138993 (Make cfg_match! a semitransparent macro)
Promise array::from_fn is generated in order of increasing indices #139099 (Promise array::from_fn is generated in order of increasing indices)
Make the compiler suggest actual paths instead of visible paths if the visible paths are through any doc hidden path. #139364 (Make the compiler suggest actual paths instead of visible paths if the visible paths are through any doc hidden path.)
Don't call Span::with_parent on the good path in has_stashed_diagnostic #139468 (Don't call Span::with_parent on the good path in has_stashed_diagnostic)
Add job summary links to post-merge report #139481 (Add job summary links to post-merge report)
Miri subtree update #139573 (Miri subtree update)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

machine clock: make 'monotonic' explicit

do not run EnvVars::cleanup if there was an interpreter error

Rustup

visit_freeze_sensitive: add comment

foreign_items: make comment more consistent

…t-provenance test-cargo-miri: permissive provenance should not be needed any more

Miri detected this bug in Mockall: asomers/mockall#647 [skip ci]

…e visible paths are through any doc hidden path.

verb -> participle Co-authored-by: Ralf Jung <[email protected]>

bump parts of test-cargo-miri to edition 2024

Add another Miri-detected bug to README.md

Cargo update

Miri subtree update r? `@ghost`

matthiaskrgr · 2025-04-09T12:52:52Z

@bors r+ rollup=never p=5

bors · 2025-04-09T12:52:55Z

📌 Commit 1aa6f70 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-04-09T12:54:26Z

⌛ Testing commit 1aa6f70 with merge 7f34062...

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#138869 (Try not to use verbatim paths in `Command::current_dir`) - rust-lang#138993 (Make `cfg_match!` a semitransparent macro) - rust-lang#139099 (Promise `array::from_fn` is generated in order of increasing indices) - rust-lang#139364 (Make the compiler suggest actual paths instead of visible paths if the visible paths are through any doc hidden path.) - rust-lang#139468 (Don't call `Span::with_parent` on the good path in `has_stashed_diagnostic`) - rust-lang#139481 (Add job summary links to post-merge report) - rust-lang#139573 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-04-09T14:38:54Z

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [assembly] tests\assembly\stack-protector\stack-protector-target-support.rs#r58 stdout ----

error in revision `r58`: auxiliary build of "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" failed to compile: 
status: exit code: 1
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--cfg" "r58" "--check-cfg" "cfg(test,FALSE,r1,r2,r3,r4,r5,r6,r7,r8,r9,r10,r11,r12,r13,r14,r15,r16,r17,r18,r19,r20,r21,r22,r23,r24,r25,r26,r27,r28,r29,r30,r31,r32,r33,r36,r37,r38,r39,r40,r41,r42,r43,r44,r45,r46,r47,r48,r49,r50,r51,r52,r53,r54,r55,r56,r57,r58,r59,r60,r61,r62,r63,r64,r65,r66,r67,r68,r69,r70,r71,r72,r73,r74,r75,r76,r77,r78,r79,r80,r81,r82,r83,r84,r85)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\assembly\\stack-protector\\stack-protector-target-support.r58\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "--target" "riscv64imac-unknown-none-elf" "-Z" "stack-protector=all" "-C" "opt-level=2" "-Cpanic=abort" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcKluPlR"

error: aborting due to 1 previous error
------------------------------------------


---
test result: FAILED. 494 passed; 1 failed; 43 ignored; 0 measured; 0 filtered out; finished in 24.34s

Some tests failed in compiletest suite=assembly mode=assembly host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:36:34
make: *** [Makefile:124: ci-mingw-x] Error 1
  local time: Wed Apr  9 14:38:36 CUT 2025
  network time: Wed, 09 Apr 2025 14:38:36 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

bors · 2025-04-09T14:39:36Z

💔 Test failed - checks-actions

matthiaskrgr · 2025-04-09T14:46:03Z

@bors retry

bors · 2025-04-09T14:48:09Z

⌛ Testing commit 1aa6f70 with merge 48f89e7...

bors · 2025-04-09T17:57:01Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 48f89e7 to master...

rust-timer · 2025-04-09T17:59:05Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#138869	Try not to use verbatim paths in `Command::current_dir`	`45128be7ef92351b1d8423a28927b049110c36db` (link)
#138993	Make `cfg_match!` a semitransparent macro	`8d5accbd461ab3b551fa0c7053bd366228809ae0` (link)
#139099	Promise `array::from_fn` is generated in order of increasin…	`3e9f985ab1b56853d23698e55d8b362031ceb1d2` (link)
#139364	Make the compiler suggest actual paths instead of visible p…	`e3ea8e1b849b2b1e7f5cfce8b49b0ce18675bafa` (link)
#139468	Don't call `Span::with_parent` on the good path in `has_sta…	`34a2dad8039a87808a32c31bc2f8c34ba1df3823` (link)
#139481	Add job summary links to post-merge report	`02a4636b581650819b63afd49adaa32a0d100cc9` (link)
#139573	Miri subtree update	`ce70c2db9a842eb20e83750dba905f0da0613158` (link)

previous master: f06e5c1e35

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-04-09T17:59:18Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f06e5c1 (parent) -> 48f89e7 (this PR)

Test differences

Show 230 test diffs

Stage 1

sys::path::windows::tests::test_is_absolute_exact: [missing] -> pass (J1)
[ui] tests/ui/process/win-command-curdir-no-verbatim.rs: [missing] -> ignore (only executed when the operating system is windows) (J2)
[ui] tests/ui/typeck/suggest-trait-reexported-as-not-doc-visible.rs: [missing] -> pass (J2)

Stage 2

[ui] tests/ui/typeck/suggest-trait-reexported-as-not-doc-visible.rs: [missing] -> pass (J0)
[ui] tests/ui/process/win-command-curdir-no-verbatim.rs: [missing] -> pass (J1)
[ui] tests/ui/process/win-command-curdir-no-verbatim.rs: [missing] -> ignore (only executed when the operating system is windows) (J3)

Additionally, 224 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Job duration changes

x86_64-apple-1: 6367.3s -> 10027.8s (57.5%)
dist-aarch64-linux: 8146.8s -> 5384.2s (-33.9%)
dist-x86_64-apple: 8504.1s -> 10157.9s (19.4%)
dist-apple-various: 5902.4s -> 6854.3s (16.1%)
dist-loongarch64-musl: 5266.2s -> 5823.9s (10.6%)
aarch64-apple: 4495.6s -> 4027.3s (-10.4%)
x86_64-gnu-distcheck: 4505.8s -> 4879.6s (8.3%)
x86_64-apple-2: 5237.7s -> 4827.3s (-7.8%)
dist-loongarch64-linux: 6218.4s -> 6608.4s (6.3%)
dist-x86_64-netbsd: 4818.9s -> 5105.9s (6.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-04-09T21:13:25Z

Finished benchmarking commit (48f89e7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 8.1%, secondary -7.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	8.1%	[8.1%, 8.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.1%	[-7.1%, -7.1%]	1
All ❌✅ (primary)	8.1%	[8.1%, 8.1%]	1

Cycles

Results (secondary -2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-3.2%, -2.8%]	5
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.721s -> 780.203s (0.06%)
Artifact size: 366.13 MiB -> 366.14 MiB (0.00%)

ChrisDenton and others added 30 commits March 24, 2025 18:57

Test Command::current_dir with verbatim path

a6e4d03

mark cfg_match! semitransparent

2c70c8a

machine clock: make 'monotonic' explicit

65bf8a8

Merge pull request rust-lang#4242 from RalfJung/clock-names

99ce8fc

machine clock: make 'monotonic' explicit

Promise array::from_fn in generated in order of increasing indices

6a91596

do not run EnvVars::cleanup if there was an interpreter error

76034a6

Merge pull request rust-lang#4243 from RalfJung/env-cleanup-too-much

4858c3f

do not run EnvVars::cleanup if there was an interpreter error

Preparing for merge from rustc

a3af09f

Merge from rustc

e435ba3

Merge pull request rust-lang#4245 from RalfJung/rustup

5103bde

Rustup

visit_freeze_sensitive: add comment

28d1844

Merge pull request rust-lang#4246 from RalfJung/freeze-sensitive-comment

1bfaa16

visit_freeze_sensitive: add comment

fix comment nit

1a89c2b

Merge pull request rust-lang#4247 from RalfJung/foreign-items-comment

1d42087

foreign_items: make comment more consistent

test-cargo-miri: permissive provenance should not be needed any more

e7de860

Merge pull request rust-lang#4249 from RalfJung/test-cargo-miri-stric…

6a43818

…t-provenance test-cargo-miri: permissive provenance should not be needed any more

Add another Miri-detected bug to README.md

05d64b1

Miri detected this bug in Mockall: asomers/mockall#647 [skip ci]

Make the compiler suggest actual paths instead of visible paths if th…

d059182

…e visible paths are through any doc hidden path.

semver-bump some dependencies

bd779df

cargo update

eb00d96

bump parts of test-cargo-miri to edition 2024

3508778

Update README.md

a503ecb

verb -> participle Co-authored-by: Ralf Jung <[email protected]>

Merge pull request rust-lang#4248 from RalfJung/edition-2024

ec1f3af

bump parts of test-cargo-miri to edition 2024

Merge pull request rust-lang#4250 from asomers/patch-1

23f1dfe

Add another Miri-detected bug to README.md

fix windows_join_multiple

e2c8ae9

Solaris does not have flock

f868322

Merge pull request rust-lang#4251 from RalfJung/cargo-update

1a4e85a

Cargo update

Preparing for merge from rustc

fa06e72

Merge from rustc

2eb7791

Don't call Span.with_parent on the good path in has_stashed_diagnostic

253da2f

Rollup merge of rust-lang#139573 - RalfJung:miri-sync, r=RalfJung

1aa6f70

Miri subtree update r? `@ghost`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 9, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2025

matthiaskrgr added the CI-spurious-fail-mingw CI spurious failure: target env mingw label Apr 9, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 9, 2025

bors merged commit 48f89e7 into rust-lang:master Apr 9, 2025
7 checks passed

rustbot added this to the 1.88.0 milestone Apr 9, 2025

bors mentioned this pull request Apr 9, 2025

Enable Non-determinism of float operations in Miri and change std tests #138062

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #139581

Rollup of 7 pull requests #139581

matthiaskrgr commented Apr 9, 2025

matthiaskrgr commented Apr 9, 2025

bors commented Apr 9, 2025

bors commented Apr 9, 2025

rust-log-analyzer commented Apr 9, 2025

bors commented Apr 9, 2025

matthiaskrgr commented Apr 9, 2025

bors commented Apr 9, 2025

bors commented Apr 9, 2025

rust-timer commented Apr 9, 2025

github-actions bot commented Apr 9, 2025

Stage 1

Stage 2

rust-timer commented Apr 9, 2025

Rollup of 7 pull requests #139581

Rollup of 7 pull requests #139581

Conversation

matthiaskrgr commented Apr 9, 2025

matthiaskrgr commented Apr 9, 2025

bors commented Apr 9, 2025

bors commented Apr 9, 2025

rust-log-analyzer commented Apr 9, 2025

bors commented Apr 9, 2025

matthiaskrgr commented Apr 9, 2025

bors commented Apr 9, 2025

bors commented Apr 9, 2025

rust-timer commented Apr 9, 2025

github-actions bot commented Apr 9, 2025

Test differences

Stage 1

Stage 2

Job duration changes

rust-timer commented Apr 9, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size