Skip to content

Conversation

Mallets
Copy link

@Mallets Mallets commented Mar 20, 2025

#94678 was closed because of time constraints of the original author (@kckeiks).

This PR is a refresh of #94678 where the original proposed changes are ported to the current status of the standard library.

In addition, this PR:

Issue: #139166

@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 20, 2025
@ibraheemdev
Copy link
Member

r? libs-api because it's been a while since the original PR was approved.

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 28, 2025
@rustbot rustbot assigned dtolnay and unassigned ibraheemdev Mar 28, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2025
@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Mar 31, 2025
@rustbot

This comment has been minimized.

@Mallets Mallets force-pushed the set_ipv6_sock_hop_limit branch from 7f790e2 to 9c1ee90 Compare March 31, 2025 10:13
@rustbot rustbot removed the has-merge-commits PR has merge commits, merge with caution. label Mar 31, 2025
@bors
Copy link
Collaborator

bors commented Apr 13, 2025

☔ The latest upstream changes (presumably #139724) made this pull request unmergeable. Please resolve the merge conflicts.

@dtolnay
Copy link
Member

dtolnay commented Apr 13, 2025

Sorry—I missed that this was ready for review again. Please use @rustbot ready, which replaces S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label with S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. .

@dtolnay dtolnay force-pushed the set_ipv6_sock_hop_limit branch from 9c1ee90 to 25fb525 Compare April 13, 2025 16:23
@dtolnay
Copy link
Member

dtolnay commented Apr 13, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2025
@dtolnay
Copy link
Member

dtolnay commented Apr 13, 2025

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 13, 2025

📌 Commit 25fb525 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 13, 2025
…=dtolnay

Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678)

rust-lang#94678 was closed because of time constraints of the original author (`@kckeiks).`

This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library.

In addition, this PR:
- implements the change suggested in rust-lang#94678 (comment)
- defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed

Issue: rust-lang#139166
@bors
Copy link
Collaborator

bors commented May 25, 2025

📌 Commit 6657c75 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request May 25, 2025
…=dtolnay

Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678)

rust-lang#94678 was closed because of time constraints of the original author (`@kckeiks).`

This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library.

In addition, this PR:
- implements the change suggested in rust-lang#94678 (comment)
- defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed

Issue: rust-lang#139166
bors added a commit that referenced this pull request May 26, 2025
Rollup of 9 pull requests

Successful merges:

 - #134696 (Implement `normalize_lexically`)
 - #138744 (Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678))
 - #140539 (Simplify `attribute_groups`)
 - #140863 ([rustdoc] Unify type aliases rendering with other ADT)
 - #140936 (Clarify WTF-8 safety docs)
 - #140952 (Specify that split_ascii_whitespace uses the same definition as is_ascii_whitespace)
 - #141472 (Attempt to improve the `std::fs::create_dir_all` docs related to atomicity)
 - #141502 (ci: move PR job x86_64-gnu-tools to codebuild)
 - #141559 (const-check: stop recommending the use of rustc_allow_const_fn_unstable)

r? `@ghost`
`@rustbot` modify labels: rollup
@jhpratt
Copy link
Member

jhpratt commented May 26, 2025

@bors r-

#141561 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2025
@Mallets
Copy link
Author

Mallets commented Aug 25, 2025

Would it be possible to re-kick the CI to get the failure logs?

@Dylan-DPC
Copy link
Member

Not sure if this reproduces the error but we can try

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 4, 2025
Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678)
@rust-bors
Copy link

rust-bors bot commented Sep 4, 2025

☀️ Try build successful (CI)
Build commit: 6b5fa05 (6b5fa054a42b37f7e0057cdcaf96ceff75677206, parent: 033c0a4742794f5608b19eb78458726596f8ec18)

@Mallets
Copy link
Author

Mallets commented Sep 4, 2025

@Dylan-DPC the build succeed

@bors
Copy link
Collaborator

bors commented Sep 11, 2025

☔ The latest upstream changes (presumably #146418) made this pull request unmergeable. Please resolve the merge conflicts.

@dtolnay
Copy link
Member

dtolnay commented Sep 17, 2025

You can reproduce the failure with x.py check library/std --target=wasm32-wasip2. "bors try" does not cover the full cross-compilation matrix.

Checking stage1 library artifacts{std} (stage1:x86_64-unknown-linux-gnu -> stage1:wasm32-wasip2)
    Checking std v0.0.0
warning: dropping unsupported crate type `dylib` for target `wasm32-wasip2`

error[E0425]: cannot find value `IPV6_MULTICAST_HOPS` in crate `c`
   --> library/std/src/sys/net/connection/socket/mod.rs:831:53
    |
831 |         setsockopt(&self.inner, c::IPPROTO_IPV6, c::IPV6_MULTICAST_HOPS, limit as c_int)
    |                                                     ^^^^^^^^^^^^^^^^^^^ help: a constant with a similar name exists: `IPV6_MULTICAST_LOOP`
    |
   ::: /home/david/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libc-0.2.175/src/wasi/p2.rs:117:1
    |
117 | pub const IPV6_MULTICAST_LOOP: c_int = 19;
    | ------------------------------------ similarly named constant `IPV6_MULTICAST_LOOP` defined here

error[E0425]: cannot find value `IPV6_MULTICAST_HOPS` in crate `c`
   --> library/std/src/sys/net/connection/socket/mod.rs:835:70
    |
835 |         let raw: c_int = getsockopt(&self.inner, c::IPPROTO_IPV6, c::IPV6_MULTICAST_HOPS)?;
    |                                                                      ^^^^^^^^^^^^^^^^^^^ help: a constant with a similar name exists: `IPV6_MULTICAST_LOOP`
    |
   ::: /home/david/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libc-0.2.175/src/wasi/p2.rs:117:1
    |
117 | pub const IPV6_MULTICAST_LOOP: c_int = 19;
    | ------------------------------------ similarly named constant `IPV6_MULTICAST_LOOP` defined here

@rustbot
Copy link
Collaborator

rustbot commented Sep 20, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment has been minimized.

@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Sep 20, 2025
@Mallets Mallets force-pushed the set_ipv6_sock_hop_limit branch from cfe9d15 to a9dbefc Compare September 20, 2025 09:20
@rustbot

This comment has been minimized.

@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Sep 20, 2025
@Mallets Mallets force-pushed the set_ipv6_sock_hop_limit branch from a9dbefc to 9698730 Compare September 20, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Operating system: Windows T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants