Skip to content

Remove AdtFlags::IS_ANONYMOUS and Copy/Clone condition for anonymous ADT #138296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

Remove AdtFlags::IS_ANONYMOUS and Copy/Clone condition for anonymous ADT #138296

merged 1 commit into from
Mar 12, 2025

Conversation

@compiler-errors
Copy link
Member

cc #131045, which removed anonymous ADTs from the compiler

I forgot more stuff I guess.

@rustbot
Copy link
Collaborator

rustbot commented Mar 10, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 10, 2025
workingjubilee
workingjubilee reviewed Mar 10, 2025
View reviewed changes
@lcnr
Copy link
Contributor

lcnr commented Mar 10, 2025

r? lcnr

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 10, 2025

📌 Commit f525b17 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 10, 2025
@jieyouxu
Rollup merge of rust-lang#138296 - compiler-errors:deanonymous, r=lcnr
a0025f4 
Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT

cc rust-lang#131045, which removed anonymous ADTs from the compiler

I forgot more stuff I guess.
@jieyouxu jieyouxu mentioned this pull request Mar 10, 2025
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 10, 2025
@jieyouxu
Rollup merge of rust-lang#138296 - compiler-errors:deanonymous, r=lcnr
7956fc6 
Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT

cc rust-lang#131045, which removed anonymous ADTs from the compiler

I forgot more stuff I guess.
@jieyouxu jieyouxu mentioned this pull request Mar 10, 2025
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 11, 2025
@jieyouxu
Rollup merge of rust-lang#138296 - compiler-errors:deanonymous, r=lcnr
71cb3b2 
Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT

cc rust-lang#131045, which removed anonymous ADTs from the compiler

I forgot more stuff I guess.
@jieyouxu jieyouxu mentioned this pull request Mar 11, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2025
@bors
Auto merge of rust-lang#138326 - jieyouxu:rollup-8p6psb1, r=jieyouxu
34d481e 
Rollup of 16 pull requests

Successful merges:

 - rust-lang#126856 (remove deprecated tool `rls`)
 - rust-lang#136932 (Reduce formatting `width` and `precision` to 16 bits)
 - rust-lang#137314 (change definitely unproductive cycles to error)
 - rust-lang#137612 (Update bootstrap to edition 2024)
 - rust-lang#138002 (Disable CFI for weakly linked syscalls)
 - rust-lang#138052 (strip `-Wlinker-messages` wrappers from `rust-lld` rmake test)
 - rust-lang#138063 (Improve `-Zunpretty=hir` for parsed attrs)
 - rust-lang#138109 (make precise capturing args in rustdoc Json typed)
 - rust-lang#138147 (Add maintainers for powerpc64le-unknown-linux-gnu)
 - rust-lang#138245 (stabilize `ci_rustc_if_unchanged_logic` test for local environments)
 - rust-lang#138296 (Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT)
 - rust-lang#138300 (add tracking issue for unqualified_local_imports)
 - rust-lang#138307 (Allow specifying glob patterns for try jobs)
 - rust-lang#138313 (Update books)
 - rust-lang#138315 (use next_back() instead of last() on DoubleEndedIterator)
 - rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js)

r? `@ghost`
`@rustbot` modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 11, 2025
@jieyouxu
Rollup merge of rust-lang#138296 - compiler-errors:deanonymous, r=lcnr
b337932 
Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT

cc rust-lang#131045, which removed anonymous ADTs from the compiler

I forgot more stuff I guess.
@jieyouxu jieyouxu mentioned this pull request Mar 11, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2025
@bors
Auto merge of rust-lang#138337 - jieyouxu:rollup-bcp7xvg, r=jieyouxu
8e3b6f6 
Rollup of 18 pull requests

Successful merges:

 - rust-lang#126856 (remove deprecated tool `rls`)
 - rust-lang#137314 (change definitely unproductive cycles to error)
 - rust-lang#137504 (Move methods from Map to TyCtxt, part 4.)
 - rust-lang#137701 (Convert `ShardedHashMap` to use `hashbrown::HashTable`)
 - rust-lang#137967 ([AIX] Fix hangs during testing)
 - rust-lang#138002 (Disable CFI for weakly linked syscalls)
 - rust-lang#138052 (strip `-Wlinker-messages` wrappers from `rust-lld` rmake test)
 - rust-lang#138063 (Improve `-Zunpretty=hir` for parsed attrs)
 - rust-lang#138109 (make precise capturing args in rustdoc Json typed)
 - rust-lang#138147 (Add maintainers for powerpc64le-unknown-linux-gnu)
 - rust-lang#138245 (stabilize `ci_rustc_if_unchanged_logic` test for local environments)
 - rust-lang#138296 (Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT)
 - rust-lang#138300 (add tracking issue for unqualified_local_imports)
 - rust-lang#138307 (Allow specifying glob patterns for try jobs)
 - rust-lang#138313 (Update books)
 - rust-lang#138315 (use next_back() instead of last() on DoubleEndedIterator)
 - rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js)
 - rust-lang#138330 (Remove unnecessary `[lints.rust]` sections.)

Failed merges:

 - rust-lang#137147 (Add exclude to config.toml)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 11, 2025
@matthiaskrgr
Rollup merge of rust-lang#138296 - compiler-errors:deanonymous, r=lcnr
522ae7f 
Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT

cc rust-lang#131045, which removed anonymous ADTs from the compiler

I forgot more stuff I guess.
This was referenced Mar 11, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2025
@bors
Auto merge of rust-lang#138366 - matthiaskrgr:rollup-cn16m7q, r=matth…
c625102 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#137715 (Allow int literals for pattern types with int base types)
 - rust-lang#138002 (Disable CFI for weakly linked syscalls)
 - rust-lang#138051 (Add support for downloading GCC from CI)
 - rust-lang#138231 (Prevent ICE in autodiff validation by emitting user-friendly errors)
 - rust-lang#138245 (stabilize `ci_rustc_if_unchanged_logic` test for local environments)
 - rust-lang#138256 (Do not feed anon const a type that references generics that it does not have)
 - rust-lang#138284 (Do not write user type annotation for const param value path)
 - rust-lang#138296 (Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT)
 - rust-lang#138352 (miri native_calls: ensure we actually expose *mutable* provenance to the memory FFI can access)
 - rust-lang#138354 (remove redundant `body`  arguments)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 954b88e into rust-lang:master Mar 12, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 12, 2025
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Mar 14, 2025
@bors
Auto merge of rust-lang#138366 - matthiaskrgr:rollup-cn16m7q, r=matth…
7d08159 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#137715 (Allow int literals for pattern types with int base types)
 - rust-lang#138002 (Disable CFI for weakly linked syscalls)
 - rust-lang#138051 (Add support for downloading GCC from CI)
 - rust-lang#138231 (Prevent ICE in autodiff validation by emitting user-friendly errors)
 - rust-lang#138245 (stabilize `ci_rustc_if_unchanged_logic` test for local environments)
 - rust-lang#138256 (Do not feed anon const a type that references generics that it does not have)
 - rust-lang#138284 (Do not write user type annotation for const param value path)
 - rust-lang#138296 (Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT)
 - rust-lang#138352 (miri native_calls: ensure we actually expose *mutable* provenance to the memory FFI can access)
 - rust-lang#138354 (remove redundant `body`  arguments)

r? `@ghost`
`@rustbot` modify labels: rollup
@Sky9x Sky9x mentioned this pull request Apr 19, 2025
Merged
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 19, 2025
@jhpratt
Rollup merge of rust-lang#140025 - Sky9x:re-remove-adtflags-anon, r=c…
c8de1ca 
…ompiler-errors

Re-remove `AdtFlags::IS_ANONYMOUS`

Removed in rust-lang#138296.
I accidentally re-added it in rust-lang#137043 while resolving merge conflicts. This PR re-removes it.

r? `@compiler-errors` (sorry)
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 19, 2025
@ChrisDenton
Rollup merge of rust-lang#140025 - Sky9x:re-remove-adtflags-anon, r=c…
9ebc73e 
…ompiler-errors

Re-remove `AdtFlags::IS_ANONYMOUS`

Removed in rust-lang#138296.
I accidentally re-added it in rust-lang#137043 while resolving merge conflicts. This PR re-removes it.

r? ``@compiler-errors`` (sorry)
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2025
@rust-timer
Unrolled build for rust-lang#140025
34ce63d 
Rollup merge of rust-lang#140025 - Sky9x:re-remove-adtflags-anon, r=compiler-errors

Re-remove `AdtFlags::IS_ANONYMOUS`

Removed in rust-lang#138296.
I accidentally re-added it in rust-lang#137043 while resolving merge conflicts. This PR re-removes it.

r? ``@compiler-errors`` (sorry)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@workingjubilee workingjubilee workingjubilee left review comments

Assignees

@lcnr lcnr

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.87.0

Development

Successfully merging this pull request may close these issues.

6 participants

@compiler-errors @rustbot @lcnr @bors @workingjubilee @davidtwco