Use `Wunused-crate-dependencies` for the compiler #137930

nnethercote · 2025-03-03T11:33:30Z

An implementation of rust-lang/compiler-team#844.

bors · 2025-03-09T16:26:02Z

☔ The latest upstream changes (presumably #138267) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-03-10T22:47:19Z

☔ The latest upstream changes (presumably #138310) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-03-13T00:40:02Z

Could not assign reviewer from: jieyouxu.
User(s) jieyouxu are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

rustbot · 2025-03-13T00:40:04Z

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in exhaustiveness checking

cc @Nadrieril

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_sanitizers

cc @rust-lang/project-exploit-mitigations, @rcvalle

nnethercote · 2025-03-13T00:41:24Z

rust-lang/compiler-team#844 has hit 10 days after seconding without objection, so is approved. And we have established RUSTC_LINT_FLAGS as the best way to handle new lints for compiler crates. So this is ready to go.

@bors rollup

Nadrieril · 2025-03-13T08:30:40Z

compiler/rustc_pattern_analysis/src/lib.rs

+#[cfg(test)]
+mod tests;
+


Why this change and why merge all the modules into a single file? Please at least leave the files separated like they were, and overall I'd prefer if this crate was structured like a normal crate, i.e. with usage tests in tests/.

I saw the commit description, I don't agree that "the rest of the compiler does it" is a good reason: this is a librarified crate, meant to be used outside of the compiler and compiled on its own (on stable even). In an ideal future this crate would be published to crates.io. These tests are meant to play with its public API surface, hence why they were integration tests.

I don't like having a "dual status" crate like this. I think it should either be a compiler crate and treated like other compiler crates, or be on crates.io (like the ena crate, for example) and then it can do things differently.

Nonetheless, the third commit it not integral and can be removed. Some level of false positive workaround is necessary for the first commit, such as the #![allow(unused_crate_dependencies)] attributes.

It still evolves sufficiently in sync with the compiler that moving out-of-tree wouldn't make sense. I expect other librarified parts of the compiler to behave similarly, how do they behave? The only other one I know of is rustc_type_ir tho.

rustc_transmute also has a rustc feature.

rustc_abi, rustc_next_trait_solver, rustc_index, rustc_ast_ir, rustc_transmute, rustc_type_ir all have a nightly feature.

I don't have a sense of whether rustc and nightly are doing the same thing. I wonder if some of these crates could be split into the "base" part (typically shared with rust-analyzer) and the rustc-specific part.

rustc_pattern_analysis could easily be split in that way. Looking at these other crates, I see:

actual nightly features (e.g. Rc::new_zeroed or Extend::extend_one);

implementing Encodable/Decodable;

whole submodules cfged-out;

internal features like rustc_pass_by_value or rustc_lint_query_instability (only in rustc_type_ir).

My guess is that we could split most of them if we had the orphan rules escape hatch that RfL wants.

jieyouxu · 2025-03-15T09:16:01Z

Commit 1 LGTM. I'll hand the review over to @Nadrieril who has a stronger preference on the test organizations.

r? @Nadrieril

bors · 2025-03-15T12:35:53Z

☔ The latest upstream changes (presumably #138464) made this pull request unmergeable. Please resolve the merge conflicts.

nnethercote · 2025-03-19T20:30:01Z

I rebased again, and again removed a couple of new unnecessary dependencies that had crept in.

@bors r=jieyouxu,Nadrieril p=1

Bumping priority because this is conflict-prone.

bors · 2025-03-19T20:30:04Z

📌 Commit f84fd39 has been approved by jieyouxu,Nadrieril

It is now in the queue for this repository.

nnethercote · 2025-03-19T20:30:24Z

@bors rollup=never

…encies, r=jieyouxu,Nadrieril Use `Wunused-crate-dependencies` for the compiler An implementation of rust-lang/compiler-team#844. r? `@jieyouxu`

bors · 2025-03-19T20:52:18Z

⌛ Testing commit f84fd39 with merge cea7074...

bors · 2025-03-19T21:43:13Z

💔 Test failed - checks-actions

It's very useful. There are some false positives involving integration tests in `rustc_pattern_analysis` and `rustc_serialize`. There is also a false positive involving `rustc_driver_impl`'s `rustc_randomized_layouts` feature. And I removed a `rustc_span` mention in a doc comment in `rustc_log` because it wasn't integral to the comment but caused a dev-dependency.

Because (a) the vast majority of compiler tests are unit tests, and (b) this works better with `unused_crate_dependencies`.

nnethercote · 2025-03-20T03:30:04Z

@bors r=jieyouxu,Nadrieril p=1

bors · 2025-03-20T03:30:07Z

📌 Commit e2320b3 has been approved by jieyouxu,Nadrieril

It is now in the queue for this repository.

jieyouxu · 2025-03-20T03:40:57Z

@bors p=10 (or else this will get rollup-raced)

bors · 2025-03-20T04:20:17Z

⌛ Testing commit e2320b3 with merge 4e2b096...

bors · 2025-03-20T07:26:38Z

☀️ Test successful - checks-actions
Approved by: jieyouxu,Nadrieril
Pushing 4e2b096 to master...

github-actions · 2025-03-20T07:28:18Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 70237a8 (parent) -> 4e2b096 (this PR)

Test differences

Show 68 test diffs

leb128::tests::test_i128_leb128 (stage 1): [missing] -> pass (J0)
leb128::tests::test_i16_leb128 (stage 1): [missing] -> pass (J0)
leb128::tests::test_i32_leb128 (stage 1): [missing] -> pass (J0)
leb128::tests::test_i64_leb128 (stage 1): [missing] -> pass (J0)
leb128::tests::test_isize_leb128 (stage 1): [missing] -> pass (J0)
leb128::tests::test_u128_leb128 (stage 1): [missing] -> pass (J0)
leb128::tests::test_u16_leb128 (stage 1): [missing] -> pass (J0)
leb128::tests::test_u32_leb128 (stage 1): [missing] -> pass (J0)
leb128::tests::test_u64_leb128 (stage 1): [missing] -> pass (J0)
leb128::tests::test_usize_leb128 (stage 1): [missing] -> pass (J0)
opaque::tests::test_bool (stage 1): [missing] -> pass (J0)
opaque::tests::test_box (stage 1): [missing] -> pass (J0)
opaque::tests::test_cell (stage 1): [missing] -> pass (J0)
opaque::tests::test_char (stage 1): [missing] -> pass (J0)
opaque::tests::test_enum (stage 1): [missing] -> pass (J0)
opaque::tests::test_hash_map (stage 1): [missing] -> pass (J0)
opaque::tests::test_i16 (stage 1): [missing] -> pass (J0)
opaque::tests::test_i32 (stage 1): [missing] -> pass (J0)
opaque::tests::test_i64 (stage 1): [missing] -> pass (J0)
opaque::tests::test_i8 (stage 1): [missing] -> pass (J0)
opaque::tests::test_isize (stage 1): [missing] -> pass (J0)
opaque::tests::test_option (stage 1): [missing] -> pass (J0)
opaque::tests::test_sequence (stage 1): [missing] -> pass (J0)
opaque::tests::test_string (stage 1): [missing] -> pass (J0)
opaque::tests::test_struct (stage 1): [missing] -> pass (J0)
opaque::tests::test_tuples (stage 1): [missing] -> pass (J0)
opaque::tests::test_u16 (stage 1): [missing] -> pass (J0)
opaque::tests::test_u32 (stage 1): [missing] -> pass (J0)
opaque::tests::test_u64 (stage 1): [missing] -> pass (J0)
opaque::tests::test_u8 (stage 1): [missing] -> pass (J0)
opaque::tests::test_unit (stage 1): [missing] -> pass (J0)
opaque::tests::test_unit_like_struct (stage 1): [missing] -> pass (J0)
opaque::tests::test_usize (stage 1): [missing] -> pass (J0)
test_bool (stage 1): pass -> [missing] (J0)
test_box (stage 1): pass -> [missing] (J0)
test_cell (stage 1): pass -> [missing] (J0)
test_char (stage 1): pass -> [missing] (J0)
test_enum (stage 1): pass -> [missing] (J0)
test_hash_map (stage 1): pass -> [missing] (J0)
test_i128_leb128 (stage 1): pass -> [missing] (J0)
test_i16 (stage 1): pass -> [missing] (J0)
test_i16_leb128 (stage 1): pass -> [missing] (J0)
test_i32 (stage 1): pass -> [missing] (J0)
test_i32_leb128 (stage 1): pass -> [missing] (J0)
test_i64 (stage 1): pass -> [missing] (J0)
test_i64_leb128 (stage 1): pass -> [missing] (J0)
test_i8 (stage 1): pass -> [missing] (J0)
test_isize (stage 1): pass -> [missing] (J0)
test_isize_leb128 (stage 1): pass -> [missing] (J0)
test_option (stage 1): pass -> [missing] (J0)
test_sequence (stage 1): pass -> [missing] (J0)
test_string (stage 1): pass -> [missing] (J0)
test_struct (stage 1): pass -> [missing] (J0)
test_tuples (stage 1): pass -> [missing] (J0)
test_u128_leb128 (stage 1): pass -> [missing] (J0)
test_u16 (stage 1): pass -> [missing] (J0)
test_u16_leb128 (stage 1): pass -> [missing] (J0)
test_u32 (stage 1): pass -> [missing] (J0)
test_u32_leb128 (stage 1): pass -> [missing] (J0)
test_u64 (stage 1): pass -> [missing] (J0)
test_u64_leb128 (stage 1): pass -> [missing] (J0)
test_u8 (stage 1): pass -> [missing] (J0)
test_unit (stage 1): pass -> [missing] (J0)
test_unit_like_struct (stage 1): pass -> [missing] (J0)
test_usize (stage 1): pass -> [missing] (J0)
test_usize_leb128 (stage 1): pass -> [missing] (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple, aarch64-gnu, i686-gnu-2, i686-gnu-nopt-2, i686-mingw-2, i686-mingw-3, i686-msvc-2, x86_64-apple-1, x86_64-gnu, x86_64-gnu-llvm-18-3, x86_64-gnu-llvm-19-3, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-2, x86_64-msvc-2

rust-timer · 2025-03-20T08:45:48Z

Finished benchmarking commit (4e2b096): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.0%	[-3.0%, -3.0%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.52s -> 773.468s (-0.01%)
Artifact size: 365.50 MiB -> 365.48 MiB (-0.01%)

This was referenced Mar 3, 2025

Use warn(unused_crate_dependencies) in compiler crates. #137911

Closed

Enable warn(unused_crate_dependencies) on rustc_*` crates rust-lang/compiler-team#844

Closed

This comment has been minimized.

Sign in to view

nnethercote force-pushed the use-Wunused-crate-dependencies branch from 9c4840f to fe01d30 Compare March 3, 2025 19:17

This comment has been minimized.

Sign in to view

nnethercote force-pushed the use-Wunused-crate-dependencies branch 2 times, most recently from 0ede122 to d73f6e5 Compare March 4, 2025 00:02

jieyouxu self-assigned this Mar 4, 2025

nnethercote mentioned this pull request Mar 5, 2025

Overhaul RUSTFLAGS handling for compiler/ crates #138035

Closed

nnethercote force-pushed the use-Wunused-crate-dependencies branch from d73f6e5 to 8650d11 Compare March 9, 2025 23:36

jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2025

nnethercote force-pushed the use-Wunused-crate-dependencies branch from 8650d11 to 2e213f8 Compare March 13, 2025 00:39

nnethercote marked this pull request as ready for review March 13, 2025 00:40

Nadrieril reviewed Mar 13, 2025

View reviewed changes

rustbot assigned Nadrieril and unassigned jieyouxu Mar 15, 2025

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 19, 2025

nnethercote force-pushed the use-Wunused-crate-dependencies branch from 1fa77ca to f84fd39 Compare March 19, 2025 20:29

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2025

nnethercote added 2 commits March 20, 2025 08:59

Convert rustc_serialize integration tests to unit tests.

e2320b3

Because (a) the vast majority of compiler tests are unit tests, and (b) this works better with `unused_crate_dependencies`.

nnethercote force-pushed the use-Wunused-crate-dependencies branch from f84fd39 to e2320b3 Compare March 19, 2025 22:00

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 20, 2025

bors merged commit 4e2b096 into rust-lang:master Mar 20, 2025
7 checks passed

rustbot added this to the 1.87.0 milestone Mar 20, 2025

nnethercote deleted the use-Wunused-crate-dependencies branch March 20, 2025 08:21

bors mentioned this pull request Mar 20, 2025

Allow drivers to supply a list of extra symbols to intern #138682

Merged

		#[cfg(test)]
		mod tests;

Use Wunused-crate-dependencies for the compiler #137930

Use Wunused-crate-dependencies for the compiler #137930

Uh oh!

Conversation

nnethercote commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Mar 9, 2025

Uh oh!

bors commented Mar 10, 2025

Uh oh!

rustbot commented Mar 13, 2025

Uh oh!

rustbot commented Mar 13, 2025

Uh oh!

nnethercote commented Mar 13, 2025

Uh oh!

Nadrieril Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

Nadrieril Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nnethercote Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

Nadrieril Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nnethercote Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

Nadrieril Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Mar 15, 2025

Uh oh!

bors commented Mar 15, 2025

Uh oh!

nnethercote commented Mar 19, 2025

Uh oh!

bors commented Mar 19, 2025

Uh oh!

nnethercote commented Mar 19, 2025

Uh oh!

bors commented Mar 19, 2025

Uh oh!

This comment has been minimized.

bors commented Mar 19, 2025

Uh oh!

nnethercote commented Mar 20, 2025

Uh oh!

bors commented Mar 20, 2025

Uh oh!

jieyouxu commented Mar 20, 2025

Uh oh!

bors commented Mar 20, 2025

Uh oh!

bors commented Mar 20, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2025

Test differences

Uh oh!

rust-timer commented Mar 20, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Use `Wunused-crate-dependencies` for the compiler #137930

Use `Wunused-crate-dependencies` for the compiler #137930

nnethercote commented Mar 3, 2025 •

edited

Loading

Nadrieril Mar 13, 2025 •

edited

Loading

Nadrieril Mar 18, 2025 •

edited

Loading

Nadrieril Mar 19, 2025 •

edited

Loading