Add `std::os::unix::process::CommandExt::chroot` to safely chroot a child process #137759

joshtriplett · 2025-02-27T23:13:08Z

This adds a chroot method to the CommandExt extension trait for the
Command builder, to set a directory to chroot into. This will chroot
the child process into that directory right before calling chdir for the
Command's working directory.

To avoid allowing a process to have a working directory outside of the
chroot, if the Command does not yet have a working directory set,
chroot will set its working directory to "/".

ACP: rust-lang/libs-team#551

This PR currently has the tracking issue set to "none"; if the ACP is approved,
I'll file a tracking issue and update the PR.

rustbot · 2025-02-27T23:13:17Z

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

bors · 2025-03-23T18:06:46Z

☔ The latest upstream changes (presumably #136929) made this pull request unmergeable. Please resolve the merge conflicts.

library/std/src/os/unix/process.rs

joshtriplett · 2025-05-20T16:05:59Z

Will rebase shortly.

…hild process This adds a `chroot` method to the `CommandExt` extension trait for the `Command` builder, to set a directory to chroot into. This will chroot the child process into that directory right before calling chdir for the `Command`'s working directory. To avoid allowing a process to have a working directory outside of the chroot, if the `Command` does not yet have a working directory set, `chroot` will set its working directory to "/".

library/std/src/os/unix/process.rs

Amanieu · 2025-05-20T21:01:59Z

@bors r+

bors · 2025-05-20T21:02:02Z

📌 Commit 33d3376 has been approved by Amanieu

It is now in the queue for this repository.

joshtriplett · 2025-05-21T04:43:50Z

Sigh. This is the kind of thing that makes me hesitate to try to use links in doc comments.

Add `std::os::unix::process::CommandExt::chroot` to safely chroot a child process This adds a `chroot` method to the `CommandExt` extension trait for the `Command` builder, to set a directory to chroot into. This will chroot the child process into that directory right before calling chdir for the `Command`'s working directory. To avoid allowing a process to have a working directory outside of the chroot, if the `Command` does not yet have a working directory set, `chroot` will set its working directory to "/". --- ACP: rust-lang/libs-team#551 This PR currently has the tracking issue set to "none"; if the ACP is approved, I'll file a tracking issue and update the PR.

bors · 2025-05-21T05:23:52Z

⌛ Testing commit 33d3376 with merge 0424534...

joshtriplett · 2025-05-21T05:38:34Z

@bors r-

Link `Command::current_dir`. Co-authored-by: Amanieu d'Antras <[email protected]>

rust-log-analyzer · 2025-05-21T05:49:11Z

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

 Documenting std v0.0.0 (/checkout/library/std)
error: unresolved link to `Command::current_dir`
   --> library/std/src/os/unix/process.rs:205:72
    |
205 |     /// This happens before changing to the directory specified with [`Command::current_dir`], and
    |                                                                        ^^^^^^^^^^^^^^^^^^^^ no item named `Command` in scope
    |
    = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`

error: unresolved link to `Command::current_dir`
   --> library/std/src/os/unix/process.rs:208:51
    |
208 |     /// If no directory has been specified with [`Command::current_dir`], this will set the directory
    |                                                   ^^^^^^^^^^^^^^^^^^^^ no item named `Command` in scope

error: could not document `std`
warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] std test:false 3.146
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:23
  local time: Wed May 21 05:48:59 UTC 2025
  network time: Wed, 21 May 2025 05:48:59 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

joshtriplett · 2025-05-21T07:11:02Z

@bors r=Amanieu

bors · 2025-05-21T07:11:05Z

📌 Commit 348c1b0 has been approved by Amanieu

It is now in the queue for this repository.

joshtriplett · 2025-05-21T07:11:12Z

@bors rollup

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#137759 (Add `std::os::unix::process::CommandExt::chroot` to safely chroot a child process) - rust-lang#140994 (replace `cc_detect::cc2ar` with `cc::try_get_archiver`) - rust-lang#141213 (Suggest use "{}", self.x instead of {self.x} when resolve x as field of `self`) - rust-lang#141283 (Allow `x perf` to find rustc.exe on Windows) - rust-lang#141284 (Allow trailing comma after argument in query definition) - rust-lang#141317 (typeck: catch `continue`s pointing to blocks) - rust-lang#141318 (Avoid creating an empty identifer in `Symbol::to_ident_string`.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#137759 - joshtriplett:command-chroot, r=Amanieu Add `std::os::unix::process::CommandExt::chroot` to safely chroot a child process This adds a `chroot` method to the `CommandExt` extension trait for the `Command` builder, to set a directory to chroot into. This will chroot the child process into that directory right before calling chdir for the `Command`'s working directory. To avoid allowing a process to have a working directory outside of the chroot, if the `Command` does not yet have a working directory set, `chroot` will set its working directory to "/". --- ACP: rust-lang/libs-team#551 This PR currently has the tracking issue set to "none"; if the ACP is approved, I'll file a tracking issue and update the PR.

…nieu Add `std::os::unix::process::CommandExt::chroot` to safely chroot a child process This adds a `chroot` method to the `CommandExt` extension trait for the `Command` builder, to set a directory to chroot into. This will chroot the child process into that directory right before calling chdir for the `Command`'s working directory. To avoid allowing a process to have a working directory outside of the chroot, if the `Command` does not yet have a working directory set, `chroot` will set its working directory to "/". --- ACP: rust-lang/libs-team#551 This PR currently has the tracking issue set to "none"; if the ACP is approved, I'll file a tracking issue and update the PR.

rustbot assigned workingjubilee Feb 27, 2025

rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 27, 2025

joshtriplett added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 27, 2025

joshtriplett mentioned this pull request Feb 27, 2025

ACP: std::os::unix::process::CommandExt::chroot rust-lang/libs-team#551

Closed

workingjubilee added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2025

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 23, 2025

tbu- reviewed Mar 31, 2025

View reviewed changes

library/std/src/os/unix/process.rs Outdated Show resolved Hide resolved

joshtriplett added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label May 16, 2025

Amanieu removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. labels May 20, 2025

This comment has been minimized.

Sign in to view

joshtriplett mentioned this pull request May 20, 2025

Tracking Issue for std::os::unix::process::CommandExt::chroot #141298

Open

4 tasks

joshtriplett added 3 commits May 20, 2025 18:25

CommandExt::chroot: Document difference to underlying chroot

c3b750c

CommandExt::chroot: Add tracking issue

17fdf19

joshtriplett force-pushed the command-chroot branch from e6dcf3a to 17fdf19 Compare May 20, 2025 16:25

Amanieu reviewed May 20, 2025

View reviewed changes

library/std/src/os/unix/process.rs Outdated Show resolved Hide resolved

library/std/src/os/unix/process.rs Outdated Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 20, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 21, 2025

Apply suggestions from code review

348c1b0

Link `Command::current_dir`. Co-authored-by: Amanieu d'Antras <[email protected]>

joshtriplett force-pushed the command-chroot branch from 33d3376 to 348c1b0 Compare May 21, 2025 05:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 21, 2025

matthiaskrgr mentioned this pull request May 21, 2025

Rollup of 7 pull requests #141331

Merged

bors merged commit 7b4f7a3 into rust-lang:master May 21, 2025
6 checks passed

rustbot added this to the 1.89.0 milestone May 21, 2025

joshtriplett deleted the command-chroot branch June 6, 2025 02:02

Uh oh!

Add std::os::unix::process::CommandExt::chroot to safely chroot a child process #137759

Add std::os::unix::process::CommandExt::chroot to safely chroot a child process #137759

Uh oh!

Conversation

joshtriplett commented Feb 27, 2025

Uh oh!

rustbot commented Feb 27, 2025

Uh oh!

bors commented Mar 23, 2025

Uh oh!

Uh oh!

This comment has been minimized.

joshtriplett commented May 20, 2025

Uh oh!

Uh oh!

Uh oh!

Amanieu commented May 20, 2025

Uh oh!

bors commented May 20, 2025

Uh oh!

This comment has been minimized.

joshtriplett commented May 21, 2025

Uh oh!

bors commented May 21, 2025

Uh oh!

joshtriplett commented May 21, 2025

Uh oh!

rust-log-analyzer commented May 21, 2025

Uh oh!

joshtriplett commented May 21, 2025

Uh oh!

bors commented May 21, 2025

Uh oh!

joshtriplett commented May 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Add `std::os::unix::process::CommandExt::chroot` to safely chroot a child process #137759

Add `std::os::unix::process::CommandExt::chroot` to safely chroot a child process #137759