Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention Drop requirements in Pin::new_unchecked #137614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mention Drop requirements in Pin::new_unchecked #137614

wants to merge 1 commit into from
+2 −2

Conversation

xizheyin
Copy link
Contributor

Fixes #134874

@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 25, 2025
@cuviper
Copy link
Member

cuviper commented Feb 25, 2025

Meta: please say more than just "fix" in pull requests. For example, I would have titled this "Mention Drop requirements in Pin::new_unchecked", so the context is clear without needing to follow the issue link.

Anyway, the change itself looks good, thank you!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 25, 2025

📌 Commit 48483ad has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2025
fmease added a commit to fmease/rust that referenced this pull request Feb 26, 2025
@fmease
Rollup merge of rust-lang#137614 - xizheyin:issue-134874, r=cuviper
0f128f4 
fix doc in library/core/src/pin.rs

Fixes rust-lang#134874
@fmease fmease mentioned this pull request Feb 26, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
@bors
Auto merge of rust-lang#137649 - fmease:rollup-59lpxdh, r=fmease
fa98c79 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#136576 (pass optimization level to llvm-bitcode-linker)
 - rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc)
 - rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis)
 - rust-lang#137529 (remove few unused args)
 - rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099))
 - rust-lang#137559 (run some tests on emscripten again)
 - rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`)
 - rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type)
 - rust-lang#137604 (trait_sel: resolve vars in host effects)
 - rust-lang#137609 (Complete the list of resources used in rustdoc output)
 - rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of)
 - rust-lang#137614 (fix doc in library/core/src/pin.rs)
 - rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute)

r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request Feb 26, 2025
@fmease
Rollup merge of rust-lang#137614 - xizheyin:issue-134874, r=cuviper
0d4af08 
fix doc in library/core/src/pin.rs

Fixes rust-lang#134874
@fmease fmease mentioned this pull request Feb 26, 2025
Open
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
@bors
Auto merge of rust-lang#137651 - fmease:rollup-s3s7m6f, r=fmease
2b3cef8 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#136576 (pass optimization level to llvm-bitcode-linker)
 - rust-lang#137154 (Add UTF-8 validation fast paths in `Wtf8Buf`)
 - rust-lang#137311 (Enable `f16` for MIPS)
 - rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc)
 - rust-lang#137529 (remove few unused args)
 - rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099))
 - rust-lang#137559 (run some tests on emscripten again)
 - rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`)
 - rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type)
 - rust-lang#137604 (trait_sel: resolve vars in host effects)
 - rust-lang#137609 (Complete the list of resources used in rustdoc output)
 - rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of)
 - rust-lang#137614 (fix doc in library/core/src/pin.rs)
 - rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute)

r? `@ghost`
`@rustbot` modify labels: rollup
@xizheyin
Copy link
Contributor Author

Meta: please say more than just "fix" in pull requests. For example, I would have titled this "Mention Drop requirements in Pin::new_unchecked", so the context is clear without needing to follow the issue link.

I'll enhance my presentation in subsequent pull requests, thanks for pointing that out!

@xizheyin xizheyin changed the title fix doc in library/core/src/pin.rs Mention Drop requirements in Pin::new_unchecked Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin::new_unchecked docs need to warn about Ptr: Drop too
4 participants
@xizheyin @rustbot @cuviper @bors