-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Create Atomic<T>
type alias (rebase)
#136316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
Atomic<T>
type alias (rebase)
Failed to set assignee to
|
This comment has been minimized.
This comment has been minimized.
b55c4f2
to
3d63489
Compare
This comment has been minimized.
This comment has been minimized.
I've removed myself from the assigned reviewer for now but feel free to assign to me again (or |
04dc387
to
db4a587
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts. |
cf23cbf
to
d66f9c2
Compare
@rustbot ready |
…Simulacrum Create `Atomic<T>` type alias (rebase) Rebase of rust-lang#130543. Additional changes: - Switch from `allow` to `expect` for `private_bounds` on `AtomicPrimitive` - Unhide `AtomicPrimitive::AtomicInner` from docs, because rustdoc shows the definition `pub type Atomic<T> = <T as AtomicPrimitive>::AtomicInner;` and generated links for it. - `NonZero` did not have this issue, because they kept the new alias private before the direction was changed. - Use `Atomic<_>` in more places, including inside `Once`'s `Futex`. This is possible thanks to rust-lang/rust-clippy#14125 The rest will either get moved back to rust-lang#130543 or rust-lang#130543 will be closed in favor of this instead. --- * ACP: rust-lang/libs-team#443 (comment) * Tracking issue: rust-lang#130539
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
18f7196
to
3537ab7
Compare
☔ The latest upstream changes (presumably #140127) made this pull request unmergeable. Please resolve the merge conflicts. |
3537ab7
to
ba6af61
Compare
☔ The latest upstream changes (presumably #140282) made this pull request unmergeable. Please resolve the merge conflicts. |
in core/alloc/std only for now, and ignoring test files Co-authored-by: Pavel Grigorenko <[email protected]>
ba6af61
to
df3dd87
Compare
@bors r+ |
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 21079f5 (parent) -> 0134651 (this PR) Test differencesShow 1400 test diffs1400 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0134651fb81314870903e21b1bcbdd993d75b61a --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (0134651): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 0.3%, secondary 0.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -0.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 762.113s -> 761.588s (-0.07%) |
Rebase of #130543.
Additional changes:
allow
toexpect
forprivate_bounds
onAtomicPrimitive
AtomicPrimitive::AtomicInner
from docs, because rustdoc shows the definitionpub type Atomic<T> = <T as AtomicPrimitive>::AtomicInner;
and generated links for it.NonZero
did not have this issue, because they kept the new alias private before the direction was changed.Atomic<_>
in more places, including insideOnce
'sFutex
. This is possible thanks todeclare_interior_mutable_const
,borrow_interior_mutable_const
: resolve<T as Trait>::AssocT
projections rust-clippy#14125The rest will either get moved back to #130543 or #130543 will be closed in favor of this instead.
Atomic<T>
libs-team#443 (comment)Atomic
#130539