Overhaul examples for PermissionsExt #136001
Open
+75
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
reviewed
Jan 24, 2025
library/std/src/os/unix/fs.rs
Outdated
| /// ); | ||
| /// | ||
| /// // file mode that we want to add in | ||
| /// let my_mode = 0o007; |
There was a problem hiding this comment.
I think you have your octets reversed -- this is world RWX, but you say owner below.
There was a problem hiding this comment.
Definitely wrong indeed. Will fix.
cuviper
reviewed
Jan 24, 2025
| /// | ||
| /// permissions.set_mode(0o644); // Read/write for owner and read for others. | ||
| /// assert_eq!(permissions.mode(), 0o644); | ||
| /// Ok(()) |
There was a problem hiding this comment.
Honestly, I think I prefer the original tighter examples. Can we just add f.set_permissions(..)?; here to solve the #91707 confusion?
There was a problem hiding this comment.
I've uplifted one of the small examples, which now also shows use of all three methods, but without a file in sight, so no confusion with file.set_permissions is possible. Best of both worlds?
rustbot
added
O-unix
|
@rustbot labels: +A-docs |
rustbot
added
the
A-docs
This comment has been minimized.
This comment has been minimized.
This fixes rust-lang#91707 by including one overarching example, instead of the small examples that can be misleading.
rustbot
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #91707 by including one overarching example, instead of the small examples that can be misleading.