Skip to content

Conversation

@ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 11, 2024

This stabilizes the core::prelude::rust_2024 and std::prelude::rust_2024 modules. I missed these in the #133349 stabilization.

@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 11, 2024
//! The prelude used in Rust 2024, [`std::prelude::rust_2024`], includes all of the above,
//! and in addition re-exports:
//!
//! * <code>[std::future]::{[Future], [IntoFuture]}</code>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, looks like all the other lines end with a . (including one fixed here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed, thanks!

@ehuss ehuss force-pushed the stabilize-2024-prelude branch from 9d45690 to 1bc5897 Compare December 11, 2024 21:10
@tgross35
Copy link
Contributor

I don't think this needs FCP but I'm just waiting on somebody from @rust-lang/libs-api to confirm

@Amanieu
Copy link
Member

Amanieu commented Dec 11, 2024

LGTM r=me

@tgross35
Copy link
Contributor

@bors r=amanieu,traviscross,tgross35 rollup

@bors
Copy link
Collaborator

bors commented Dec 11, 2024

📌 Commit 1bc5897 has been approved by amanieu,traviscross,tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2024
@bors bors merged commit 90f6b27 into rust-lang:master Dec 12, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 12, 2024
@ehuss ehuss added the A-edition-2024 Area: The 2024 edition label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-edition-2024 Area: The 2024 edition S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants