Impl String::into_chars #133057
Open
Impl String::into_chars #133057
+92
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to set assignee to
|
rustbot
added
S-waiting-on-review
tisonkun
commented
Nov 15, 2024
| None => None, | ||
| Some((_, ch)) => { | ||
| let offset = iter.offset(); | ||
| drop(self.bytes.drain(..offset)); |
There was a problem hiding this comment.
This reminds me of this thread that suggests a truncate_front method on Vec. Not sure if it's desired as a separate proposal.
tisonkun
commented
Nov 15, 2024
| match iter.next_back() { | ||
| None => None, | ||
| Some((idx, ch)) => { | ||
| self.bytes.truncate(idx); |
There was a problem hiding this comment.
I don't use vec::IntoIter as the snippet suggested at rust-lang/libs-team#268 (comment) because for next_back, we'd be dropping elements from the back. It's possible to loop self.bytes_iter.next_back(), but using a Vec seems a net win.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: tison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @programmerjake @kennytm @Amanieu
This refers to rust-lang/libs-team#268
Before adding tests and creating a tracking issue, I'd like to reach a consensus on the implementation direction and two questions:
String::into_char_indicesmethod also?