Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand CloneToUninit documentation. #133055

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Expand CloneToUninit documentation. #133055

wants to merge 2 commits into from
+135 −28

Conversation

kpreid
Copy link
Contributor

@kpreid kpreid commented Nov 14, 2024

  • Clarify relationship to dyn after Make CloneToUninit dyn-compatible #133003.
  • Add an example of using it with dyn as Make CloneToUninit dyn-compatible #133003 enabled.
  • Replace parameter name dst with dest to avoid confusion between abbreviations for “DeSTination” and “Dynamically-Sized Type”.
  • Add an example of implementing it.
  • Add links to Rust Reference for the mentioned concepts.
  • Mention that its method should rarely be called.
  • Various small corrections.

Please review the unsafe code closely, as I am not an expert in the best possible ways to express these operations. (It might also be better to omit the implementation example entirely.)

cc @zachs18 #126799

@kpreid
Expand CloneToUninit documentation.
76b565f 
* Clarify relationship to `dyn` after rust-lang#133003.
* Add an example of using it with `dyn` as rust-lang#133003 enabled.
* Add an example of implementing it.
* Add links to Rust Reference for the mentioned concepts.
* Mention that its method should rarely be called.
* Various small corrections.
@kpreid
Replace parameter name dst with dest.
d1b4992 
This avoids confusion between “DeSTination” and “Dynamically-Sized Type”.
@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 14, 2024
@kpreid kpreid changed the title Clone uninit doc Expand CloneToUninit documentation. Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpreid @rustbot @cuviper