Add peek_index to Enumerate

[x4exr]

ACP rust-lang/libs-team#435 (comment)

[rustbot]

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[cuviper]

While I do like the name peek_index, it's not what the libs-api team agreed on. This should be implemented as next_index like they preferred, and then peek_index or other names can be discussed in the tracking issue.

[cuviper]

@rustbot author

[x4exr]

While I do like the name peek_index, it's not what the libs-api team agreed on. This should be implemented as next_index like they preferred, and then peek_index or other names can be discussed in the tracking issue.

My apologies, once I return today I will update the PR.

[tgross35]

Just an fyi, this should get a squash before merge

[alex-semenyuk]

@x4exr
From wg-triage. Do you have any updates on this PR?

[x4exr]

Iirc i was supposed to change the feature name before this is ready to merge

[alex-semenyuk]

@x4exr
Thanks for your contribution.

Iirc i was supposed to change the feature name before this is ready to merge

Could you please do this and

Just an fyi, this should get a squash before merge

[x4exr]

if I'm being honest I have no clue what I'm doing with git
I once tried squashing this and it vasicly did nothing

[tgross35]

It should be something like git rebase -i master --keep-base (--keep-base means it won't actually change the base, i.e. rebases on to whatever master looked like when you created the branch rather than what master looks like today). This will open an editor with a bunch of lines starting with pick ... (one line per commit). For everything except the first commit, change pick to f or fixup, then save & quit.

This will combine all later commits into the first one, discarding their messages (s or squash instead of f would combine their messages, but it doesn't look like there is anything to keep here). Then once that is done, check that git log/git show HEAD looks correct and git push --force-with-lease to update the PR.

[Dylan-DPC]

@x4exr any updates on this? thanks