Skip to content

move Option::as_(mut_)slice to use offset_of!, part 1 #117594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Nov 4, 2023

This does the bootstrap dance to use the newly-added enum extension of the core::mem::offset_of! macro. Once that reaches beta, we can remove the bootstrap and the intrinsic.

r? @scottmcm

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 4, 2023
@the8472
Copy link
Member

the8472 commented Nov 5, 2023

Seems redundant with #117525

@llogiq
Copy link
Contributor Author

llogiq commented Nov 5, 2023

It's basically a stepping stone, ensuring both implementations work. But I'm ok with waiting for it to unblock.

@GKFX
Copy link
Contributor

GKFX commented Nov 17, 2023

@llogiq I think this two-part approach is no longer required, as after the current beta was created #117525 is able to remove the intrinsic directly.

@llogiq llogiq closed this Nov 17, 2023
@llogiq llogiq deleted the option-as-slice-via-offset-of branch November 17, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants