- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Increase parallelism in various locations #115003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| (rustbot has picked a reviewer for you, use r? to override) | 
| @bors try @rust-timer queue | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| ⌛ Trying commit f9d12e2a6022cbbed60f458a78502791ec77ccef with merge 5f30bb0cbc3842d6520bacf4d7dea860e138c4d9... | 
| ☀️ Try build successful - checks-actions | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
f9d12e2    to
    1821289      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| Finished benchmarking commit (5f30bb0cbc3842d6520bacf4d7dea860e138c4d9): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with  @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment. 
 Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment. 
 CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment. 
 Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment. 
 Bootstrap: 636.001s -> 635.653s (-0.05%) | 
1821289    to
    d125a5d      
    Compare
  
    | I avoided prefetching of  | 
| @bors try @rust-timer queue | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| ⌛ Trying commit d125a5d8c1dc23342aa5641675df34d33a76958f with merge 78a3877375fe23c25e4c0ea3ff01b84d806cd35d... | 
| ☀️ Try build successful - checks-actions | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| Finished benchmarking commit (78a3877375fe23c25e4c0ea3ff01b84d806cd35d): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment. 
 Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment. 
 CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment. 
 Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 636.195s -> 635.468s (-0.11%) | 
946b97d    to
    8747443      
    Compare
  
    | ☔ The latest upstream changes (presumably #115401) made this pull request unmergeable. Please resolve the merge conflicts. | 
8747443    to
    dc4688b      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
dc4688b    to
    e26db41      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
e26db41    to
    a07cb22      
    Compare
  
    | ☔ The latest upstream changes (presumably #116482) made this pull request unmergeable. Please resolve the merge conflicts. | 
a07cb22    to
    ec1df88      
    Compare
  
    | ☔ The latest upstream changes (presumably #120112) made this pull request unmergeable. Please resolve the merge conflicts. | 
ec1df88    to
    01ae9a3      
    Compare
  
    | ☔ The latest upstream changes (presumably #121154) made this pull request unmergeable. Please resolve the merge conflicts. | 
| @Zoxc Any updates on this? Thanks | 
| You can probably consider this blocked on rust-lang/rustc-rayon#12. | 
01ae9a3    to
    e703606      
    Compare
  
    | ☔ The latest upstream changes (presumably #138499) made this pull request unmergeable. Please resolve the merge conflicts. | 
e703606    to
    b0f6da4      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
b0f6da4    to
    9391a4a      
    Compare
  
    | ☔ The latest upstream changes (presumably #134767) made this pull request unmergeable. Please resolve the merge conflicts. | 
9391a4a    to
    9263df8      
    Compare
  
    | ☔ The latest upstream changes (presumably #140959) made this pull request unmergeable. Please resolve the merge conflicts. | 
9263df8    to
    3516544      
    Compare
  
    | This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. | 
| ☔ The latest upstream changes (presumably #147140) made this pull request unmergeable. Please resolve the merge conflicts. | 
This is a rebase of #67870 which consists of various additions of parallelism in the compiler.
Performance improvement for the parallel compiler with 6 threads:
cc @SparrowLii