Skip to content

Wrap the return value of the type_id intrinsic in an opaque box #10722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2013
Merged

Wrap the return value of the type_id intrinsic in an opaque box #10722

merged 1 commit into from
Nov 30, 2013

Conversation

emberian
Copy link
Member

Closes #10594

@emberian
Copy link
Member Author

I'm having a bit of difficulty with this one. When building stdtest, it gives:

│compile_and_link: x86_64-unknown-linux-gnu/stage1/test/stdtest-x86_64-unknown-linux-gnu
│/home/cmr/hacking/rust/src/libstd/any.rs:221:19: 221:28 error: failed to find an implementat
│ion of trait to_bytes::IterBytes for std::unstable::intrinsics::TypeId
│/home/cmr/hacking/rust/src/libstd/any.rs:221         assert_eq!(a.hash(), b.hash());
│                                                                ^~~~~~~~~
│<std-macros>:54:4: 67:5 note: in expansion of assert_eq!

Yet it's right there. What am I doing wrong?

@@ -183,6 +191,7 @@ mod tests {
use super::AnyRefExt;
use option::{Some, None};
use hash::Hash;
use realstd::unstable::intrinsics::TypeId;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use realstd here?

@alexcrichton
Copy link
Member

This may be having trouble because it's seeing an implementation of realstd::to_bytes::IterBytes, but it's not seeing an implementation of std::to_bytes::IterBytes. Just a guess though?

@emberian
Copy link
Member Author

@alexcrichton does the same with most recent commit (using std instead of realstd). I really don't understand how libstd testing is set up at all...

@alexcrichton
Copy link
Member

I think that this is the point where the boundary of testing libstd and running libstd gets so blurred that it's fine to move the relevant tests into a src/test/run-pass file.

bors added a commit that referenced this pull request Nov 30, 2013
@bors bors closed this Nov 30, 2013
@bors bors merged commit 572635b into rust-lang:master Nov 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap the return value of the type_id intrinsic in an opaque box
3 participants