autoload/rustfmt.vim slowdown vim startup #527
+60
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Replace DetectVersion() with rust-settings.
Relative rust-settings:
* rustfmt_emitmode_legacy
* rustfmt_format_range
* rustfmt_use_configfile
fixes rust-lang#524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #524
rustfmt.vimwant to switch config option automatically between differencerustfmtversion according detect version and check supported option ofrustfmt. But this design causing more trouble than convenience for users.According this change, we not need to call
rustfmt --versionandrustfmt --helpanymore. If we need to support new feature:g:rustfmt_xxx_legacyrustfmtoption and it can't be config in configuration file, providing optiong:rustfmt_xxx_xxx. We don't care about it isnightlyorstable, we just make sure: If it isnightlyonly, then it work onnightlyversion. If it is both, then it work on both. That is it.g:rustfmt_use_configfile. If set to 1, using config file; otherwise using default (current is--edition 2018).more details in this comment and relative issue in vim