Skip to content

Rollup of 4 pull requests #4790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Nov 7, 2019

Successful merges:

Failed merges:

r? @ghost

evanjs and others added 19 commits October 30, 2019 21:05
- Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py
Remove recalculation of literal value.
Co-Authored-By: Philipp Krones <[email protected]>
Co-Authored-By: Philipp Krones <[email protected]>
restriction lint for `std::process::exit`

Addition to rust-lang#4655 - adds the lint checking for `std::process::exit`

changelog: add restriction lint for `std::process::exit`
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes rust-lang#4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those rust-lang#4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
`DecimalLiteralRepresentation` simplification

Remove recalculation of literal value.

changelog: none
don't warn on CRLF in `with_newline` lints

changelog: don't warn on CRLF in `print_with_newline` and `write_with_newline`
fixes rust-lang#4208.

This PR also transitions the unescaping logic to use the compiler's lexer.
@flip1995
Copy link
Member Author

flip1995 commented Nov 7, 2019

@bors r+ p=4 rollup=never

@bors
Copy link
Contributor

bors commented Nov 7, 2019

📌 Commit 2df272b has been approved by flip1995

@bors
Copy link
Contributor

bors commented Nov 7, 2019

🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened

@Manishearth
Copy link
Member

@bors treeclose- retry

@Manishearth
Copy link
Member

@bors treeclosed-

@bors
Copy link
Contributor

bors commented Nov 7, 2019

⌛ Testing commit 2df272b with merge f112422...

bors added a commit that referenced this pull request Nov 7, 2019
Rollup of 4 pull requests

Successful merges:

 - #4697 (restriction lint for `std::process::exit`)
 - #4757 (Fix Deprecated lints don't expand)
 - #4758 (`DecimalLiteralRepresentation` simplification)
 - #4769 (don't warn on CRLF in `with_newline` lints)

Failed merges:

r? @ghost
@Manishearth
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Nov 7, 2019

⌛ Testing commit 2df272b with merge 6eb40e0...

bors added a commit that referenced this pull request Nov 7, 2019
Rollup of 4 pull requests

Successful merges:

 - #4697 (restriction lint for `std::process::exit`)
 - #4757 (Fix Deprecated lints don't expand)
 - #4758 (`DecimalLiteralRepresentation` simplification)
 - #4769 (don't warn on CRLF in `with_newline` lints)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Nov 7, 2019

💔 Test failed - checks-travis

@flip1995 flip1995 closed this Nov 8, 2019
@flip1995 flip1995 deleted the rollup-8rnsng6 branch May 4, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants