compiletest: Disambiguate extern crate deps shared with the compiler #4017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow, this is cool. Although I think we should try to upstream stuff like this to compiletest-rs, we can play with it here until we have the kinks worked out. You have a dogfood failure (basically make the entire thing one big |
Xanewok
commented
Apr 22, 2019
Xanewok
force-pushed
the
wip-disambiguate-extern
branch
from
91c145d to
56389f3
Compare
|
@bors r+ p=42 |
|
📌 Commit 56389f3 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 23, 2019
compiletest: Disambiguate extern crate deps shared with the compiler Fixes #4015. changelog: Handle deps shared with the compiler in the internal compiletest suite Attempts to fix the multiple matching crates error using the `--extern dep=path` disambiguation. This only includes `serde` at the moment because it's the only problematic dep right now (is inside Rust sysroot and pulled via `extern crate` in the test suite). I'm not exactly sure this is the right approach (FWIW it fixes the issue locally), please do tell if this should be done differently.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4015.
changelog: Handle deps shared with the compiler in the internal compiletest suite
Attempts to fix the multiple matching crates error using the
--extern dep=pathdisambiguation. This only includesserdeat the moment because it's the only problematic dep right now (is inside Rust sysroot and pulled viaextern cratein the test suite).I'm not exactly sure this is the right approach (FWIW it fixes the issue locally), please do tell if this should be done differently.