-
Notifications
You must be signed in to change notification settings - Fork 1.7k
add lint infallible_try_from #14813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add lint infallible_try_from #14813
Conversation
This comment has been minimized.
This comment has been minimized.
r? @llogiq Written at the workshop during RustWeek |
d4eee17
to
5c0bd96
Compare
This is a good start. The code is still failing dogfood, where clippy lints itself. Looking at the suggestions, you should change the "default lint description" in the lint definition block, and use a |
Should be ready to go now |
Thank you! I've just started the final comment period. In the meantime, can you please squash your commits? |
f710528
to
0d3545f
Compare
Thanks! Squashed |
Small heads-up: Your lint is well received. There is some discussion about the lint group though. It may end up in |
And another update: Looks like it should go into the |
0d3545f
to
ab3786a
Compare
Looks for `TryFrom` implementations with uninhabited error types and suggests to implement `From` instead.
ab3786a
to
8e581e3
Compare
Looks for
TryFrom
implementations with uninhabited error types and suggests to implementFrom
instead.Fixes #2144
changelog: Added [
infallible_try_from
] tonursery