Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: option_if_let_else FP when value partially moved #14209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: option_if_let_else FP when value partially moved #14209

wants to merge 1 commit into from
+115 −2

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Feb 13, 2025 •
edited
Loading

fixes #13964

The lint option_map_unwrap_or used to have a similar issue in #10579, so I borrowed its solution to fix this one.

changelog: [option_if_let_else]: fix FP when value partially moved

@rustbot
Copy link
Collaborator

rustbot commented Feb 13, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 13, 2025
@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned blyxyas and unassigned llogiq Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggested map_or_else when value partialy moved
4 participants
@profetia @rustbot @llogiq @blyxyas