Rust 1.81 and later support elision with explicit self types #13992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
push-xqstlqqyrkny
branch
from
e3c59c7 to
94ff89d
Compare
Alexendoo
reviewed
Jan 13, 2025
samueltardieu
force-pushed
the
push-xqstlqqyrkny
branch
from
94ff89d to
85ca671
Compare
Commit 9ef6e21 introduced a check to ensure that Clippy doesn't consider a lifetime present in an explicit self type as being the default for an elided output lifetime. For example, elision did not work in the case like: ```rust fn func(self: &Rc<Self>, &str) -> &str { … } ``` Since Rust 1.81.0, the lifetime in the self type is now considered the default for elision. Elision should then be suggested when appropriate.
samueltardieu
force-pushed
the
push-xqstlqqyrkny
branch
from
85ca671 to
8b7cfc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9ef6e21 introduced a check to ensure that Clippy doesn't consider a lifetime present in an explicit self types as being the default for an elided output lifetime. For example, elision did not work in the case like:
Since Rust 1.81.0, the lifetime in the self type is now considered the default for elision. Elision should then be suggested when appropriate.
changelog: [
needless_lifetimes]: suggest elision of lifetimes present in explicit self types as wellr? @Alexendoo
because of #8278