fix: undocumented_unsafe_blocks FP on trait/impl items

[profetia]

fixes #11709

Continuation of #12672. r? @Alexendoo if you don't mind?

changelog: [undocumented_unsafe_blocks] fix FP on trait/impl items

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[profetia]

r? clippy

[Manishearth]

r? clippy

on a work trip and my notifications are packed

[xFrednet]

LGTM, thank you for the update (And sorry for the delay with the review. 😅 )

---

Roses are red,
Violets are blue,
Safety comments,
For unsafe code

[profetia]

Looks like it is conflicted with the recent update on ui toml. Should be ok now, you may need to re-press the button though @xFrednet.

[xFrednet]

Thanks for the rebase!

I've checked the CI lintcheck output: https://github.com/rust-lang/rust-clippy/actions/runs/13364592312?pr=13888 and actually noticed a regression here: https://docs.rs/time/0.3.36/src/time/offset_date_time.rs.html#35. The linked code would now be linted while it wasn't before. Could you take a look at it and add a test?

[profetia]

@xFrednet Can you check it now? I fixed that one and we also got 9 cases REMOVED. How wiered that this one in time-rs does not exist initially.

[xFrednet]

@xFrednet Can you check it now? I fixed that one and we also got 9 cases REMOVED. How wiered that this one in time-rs does not exist initially.

This is super nice, all of them have been FPs that you fixed now :D

It might be that the lint is still incorrectly emitted. The CI only shows the difference. But I don't think we should block on this. This PR has already been open for quite some time :)

[xFrednet]

This version looks good to me, could you rebase one last time?

Thank you for your patience while waiting on my review 😅

[profetia]

This version looks good to me, could you rebase one last time?

Thank you for your patience while waiting on my review 😅

Rebased

[xFrednet]

// Safety: The following poem is not complete
unsafe {
    Rose are red,
    Violets are blue
}