-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new lint non_std_lazy_statics
#13770
Open
pitaj
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
pitaj:non_std_lazy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
label
Dec 1, 2024
pitaj
changed the title
add new lint [
add new lint Dec 1, 2024
non_std_lazy_statics
]non_std_lazy_statics
detect usage of `once_cell::sync::Lazy` and `lazy_static!`, recommending usage of `std::sync::LazyLock` instead
☔ The latest upstream changes (presumably a5e46a6) made this pull request unmergeable. Please resolve the merge conflicts. |
Thank you. This looks like a solid improvement, it just needs a rebase. |
@pitaj ping? Can you rebase? |
@llogiq sorry about the late response. Based on zulip discussion, I need to make a couple of changes:
|
@rustbot author |
rustbot
added
S-waiting-on-author
Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
labels
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-author
Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12895
detects usage of
once_cell::sync::Lazy
andlazy_static!
, recommending usage ofstd::sync::LazyLock
insteadMany thanks to @J-ZhengLi for putting in most of the work in #12968
changelog: new lint
non_std_lazy_statics