Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] borrow_deref_ref: do not trigger on &raw references #13619

Closed
wants to merge 1 commit into from

Conversation

samueltardieu
Copy link
Contributor

Backport of #13600, tested in Rust beta sources.

changelog: [borrow_deref_ref]: do not trigger on &raw references

r? @xFrednet

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 28, 2024
@xFrednet
Copy link
Member

Hey Samuel, usually backports are done all together by @flip1995 one week before the release. I usually see the changes in the Rust repo, where a PR is created into the beta branch. I know that the documentation states that the first step is to get it onto the Clippy beta branch, but I'm not sure how this is usually done.

@flip1995 Could you maybe comment on this? Also do we want to merge this or let you do the normal backport before the next release?

@samueltardieu
Copy link
Contributor Author

I wondered about it, and I haven't seen anything in https://doc.rust-lang.org/nightly/clippy/development/infrastructure/backport.html so I wanted to try the process. I'm fine with closing this PR and letting @flip1995 merge all beta-nominated issues.

@flip1995
Copy link
Member

The backport documentation is completely outdated. I updated the documentation in #12762, but I mixed it with the Josh move documentation. I plan to split things that are unrelated to Josh out of this and the other Josh PR.

I will include the nominated PR in the beta backport.

Merging this in the Clippy repo does nothing. The beta and stable branches are only there for documentation deployment nowadays.

@flip1995 flip1995 closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants