Avoid using the tests folder for the file manipulation test #985
Conversation
|
That was quick, wow! But why would that work? Now it expects the file in the working directory instead of one level down, which still isn't where the file actually is. |
|
That works because the test creates the file, then writes to it, then reads from it and then it deletes the file. The first version just assumed the file was there but now we don't need that anymore. |
|
Ah, that must be in the PR I didn't get to review yet. ;) |
|
Heh, yeah that's exactly why. So, this would only pollute the build dir if the test fails, but hopefully travis will catch that issue even before someone decides to bump miri. |
|
Maybe give the file a better name then in case it doesn't get cleaned up, like |
|
sure |
|
Thanks a lot! @bors r+ |
|
📌 Commit e9138ab has been approved by |
Avoid using the tests folder for the file manipualtion test rust-lang/rust#65278 r? @RalfJung
RalfJung
changed the title
|
☀️ Test successful - checks-travis, status-appveyor |
rust-lang/rust#65278 r? @RalfJung