-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset #2675
Reset #2675
Conversation
@Mark-Simulacrum could I ask you again to temporarily disable branch protection in Miri? We ran into a josh bug and I don't know how to repair this without a Miri force-push. (The faulty commit landed in rustc with rust-lang/rust#104456, but we can't force-push there obviously. This way we sync the fault back to Miri and therefore define it to be the correct history.) I have updated our scripts so in the future we should be able to detect such faulty pushes before we merge them in rustc. I also confirmed that this commit does round-trip properly. Cc @rust-lang/miri |
I think the oldest commit we need to get out of our history is 218f60e. I will verify by seeing where this history branches from master.
|
Yes this branch does not contain 218f60e but contains both of its parents. Good. |
Allowed force push to users with push access. |
Hm, that does not seem to work...
|
Try again now? I think there was another toggle I needed to hit |
Now it worked. :) Thanks! Please protect the branch again. |
Done. |
This is the Miri history as extracted from current rustc, with the PRs since the last push applied by hand. It is identical to #2673. I think we should force-push Miri to this commit.