whitelist platforms where panicking should work #1241
Conversation
|
Hm no this will probably be too late, actually... I think the RwLock is acquired earlier. We probably need to abort already in |
|
I moved the check further "up", i.e. it is now checking earlier and hopefully should no longer reach the bad |
|
I would test it but I'm having trouble getting miri to build from my (windows) machine. Whichever path I'm trying I fail to find |
|
Well, let's see if this test passes then. |
|
📌 Commit 0ae6288 has been approved by |
whitelist platforms where panicking should work @CAD97 [proposed](#1059 (comment)) trying to get a better error for failed panics on Windows. Could you test if this works for you?
|
💔 Test failed - status-appveyor |
|
Nope... there's no "hooked" function on Windows that we can intercept to get a proper error. :/ |
Is the |
|
Ah, that's almost certainly it. |
|
Filled rust-lang/rust#70157 for a better error message. |
|
📌 Commit bde3111 has been approved by |
whitelist platforms where panicking should work @CAD97 [proposed](#1059 (comment)) trying to get a better error for failed panics on Windows. Could you test if this works for you?
|
💔 Test failed - status-appveyor |
|
@bors r+ |
|
📌 Commit 7a10c9d has been approved by |
whitelist platforms where panicking should work @CAD97 [proposed](#1059 (comment)) trying to get a better error for failed panics on Windows. Could you test if this works for you?
|
💔 Test failed - status-appveyor |
|
@bors r+ |
|
📌 Commit 5c09047 has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
@CAD97 proposed trying to get a better error for failed panics on Windows.
Could you test if this works for you?