Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in waitpid parameter name #4334

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

jimmycathy
Copy link
Contributor

@jimmycathy jimmycathy commented Mar 16, 2025

Description

Corrected parameter spelling from 'optons' to 'options' in waitpid declaration. This matches POSIX standard naming for the options parameter used to specify waitpid behavior flags like WNOHANG and WUNTRACED.

ref: https://pubs.opengroup.org/onlinepubs/9699919799/functions/waitpid.html

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 22, 2025
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a permalink to sources to the PR description for reference, otherwise lgtm.

@jimmycathy
Copy link
Contributor Author

Please add a permalink to sources to the PR description for reference, otherwise lgtm.

Thanks. Modified.

Please review again.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 added this pull request to the merge queue Apr 1, 2025
Merged via the queue into rust-lang:main with commit 0cea762 Apr 1, 2025
42 of 43 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 3, 2025
Signed-off-by: jimmycathy <[email protected]>

(backport <rust-lang#4334>)
(cherry picked from commit 2c85704)
@tgross35 tgross35 mentioned this pull request Apr 3, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants