-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the ctest2
repository into libc
#4283
base: main
Are you sure you want to change the base?
Conversation
Add target_endian to the set of #[cfg()] items that are considered.
Add support for unions without typedefs
improve docs of cfg method
Being able to call `const fn` on stable is a relatively new addition. CC rust-lang#1075
Revert bump in the minimum supported Rust version
Minimal support for fn types in extern statics
Add support for arrays in extern statics
update libc test
Skip signedness checks for type aliases of non-integer types
Signed-off-by: Florian Bartels <[email protected]>
Signed-off-by: Florian Bartels <[email protected]>
Add support for alternative network stack io-sock on QNX 7.1
fix: Declare explicit "C" ABI on `extern` blocks/fns
chore: Release v0.4.10
chore: Configure Renovate
Prepare for merging into `libc` by moving everything to a subdirectory so names do not conflict.
Absorb the `ctest2` project and its history into `libc`. Original HEAD: https://github.com/JohnTitor/ctest2.git Latest HEAD ref: 0563471
We will be able to publish the crate under the original `ctest` name, so update its name and URLS here.
@tgross35: no appropriate reviewer found, use |
@JohnTitor would you be okay with libc absorbing ctest2, or do you have any concerns? You can continue to maintain it here if you wish of course. |
Also, does anyone know of a better way to merge unrelated histories? The blame works fine but the log appears empty. |
I think I've done something like this in the past using |
r? @JohnTitor I of course don't want to poach your fork without your okay, so I'll assign you :) if you're fine going forward, I'll get the history better integrated as Alex suggested before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, no objection. Thank you!
Some crates use ctest2 in their tests, so maybe I should add a deprecation notice and encourage to migrate in the |
libc
's testing is pretty tightly coupled toctest2
, which is a reasonably simple crate that maps Rust syntax to C syntax and creates tests based off of that.ctest2
itself is a fork ofctest
.Unfortunately, relying on
ctest(2)
has been somewhat of a problem since it supports only a very outdated version of Rust's syntax, and there are a handful of other bugs. There have been some GSoC proposals to modernizelibc
and its test crates; movingctest
to a rust-lang repo makes that easier and should come with some maintenance benefits.On Zulip, @alexcrichton confirmed ownership of the original
ctest
crate could be transferred to rust-lang so we can continue publishing under that name, for other repos that make use ofctest
/ctest2
.This pull only brings over the repo source and history as it currently exists. I will need to follow up with integration of the CI and release workflows.