Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use criterion for benchmark #609

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

ldm0
Copy link
Contributor

@ldm0 ldm0 commented Mar 2, 2025

Supercedes #243
Related to #4

Version of rayon was changed from ^1.2 to ^1.3 since it's required by criterion.

@Amanieu
Copy link
Member

Amanieu commented Mar 7, 2025

You'll need to bump the minimum Rust version to 1.74 in Cargo.toml and in the CI configuration. Since Cargo now supports MSRV-aware resolution.

@ldm0 ldm0 force-pushed the bench_criterion branch from 9cedd3f to 63968ab Compare March 11, 2025 13:58
@ldm0 ldm0 force-pushed the bench_criterion branch from 7d506e3 to 132d31e Compare March 11, 2025 14:45
@ldm0
Copy link
Contributor Author

ldm0 commented Mar 11, 2025

@Amanieu done

@cuviper
Copy link
Member

cuviper commented Mar 11, 2025

Personally, I've come to prefer divan, but it's not terribly important either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants