Send email on crate owner invitation #1909
Conversation
If the recipient of a crate ownership invitation has a verified email address, they will be sent an email indicating that a specified user has invited them to become an owner of a named crate. Only sends the email on the first instance of an invitation.
|
r? @jtgeibel (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
It's working great! I tried it out locally and I saw an email sent when I invited another user to a crate! 🎉
The code is really close! I think the email subject could use a tiny bit of tweaking, and we can get rid of a conditional in the krate model. Let me know if you have any questions! Thank you!!!
|
I made the requested changes as an additional commit, but if preferred, I can squash that down to just the one. |
nkanderson
force-pushed
the
1360_email_invitation
branch
from
0c7de44 to
cef0429
Compare
|
Whoops, looks like I had a formatting issue initially, should be ok now though. |
|
Looks great now!! Thank you so much!! @bors r+ |
|
📌 Commit cef0429 has been approved by |
Send email on crate owner invitation If the recipient of a crate ownership invitation has a verified email address, they will be sent an email indicating that a specified user has invited them to become an owner of a named crate. Only sends the email on the first instance of an invitation. Completes the first part of #1360.
|
☀️ Test successful - checks-travis |
If the recipient of a crate ownership invitation has a verified email address, they will be sent an email indicating that a specified user has invited them to become an owner of a named crate. Only sends the email on the first instance of an invitation.
Completes the first part of #1360.