Add DELETE /api/v1/trusted_publishing/tokens API endpoint
#11234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
19 tasks
|
Would you be willing to also add some regression tests? Specifically around cross-crate and user manipulation. This could probably apply to some of the other endpoints as well. Id feel better just covering any future errors. |
|
absolutely, but could you be slightly more specific on the exact scenarios you would like to see tested? :) |
Turbo87
force-pushed
the
trustpub-revoke
branch
2 times, most recently
from
1141dd8 to
a9cde09
Compare
LawnGnome
approved these changes
May 28, 2025
This makes it possible to construct `MockTokenUser` instances from an existing plaintext token or other random header value.
|
#11131 has been merged, so this PR is now muuuuch smaller and ready for review :) |
eth3lbert
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an endpoint to revoke a temporary access token from the Trusted Publishing flow.
The
DELETE /api/v1/trusted_publishing/tokensendpoint expects the token to be handed over in theAuthorizationheader as aBearertoken, similar to how it will be used in the publish endpoint.This PR is based upon (and currently includes the changes of) #11131, which implements the API endpoint to create a temporary access token (from a JWT).
Related:
PUT /api/v1/trusted_publishing/tokensAPI endpoint #11131