Require owner approval #1108
Merged
Require owner approval #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replicates what was previously done in the owner_add function of krate.rs, adding an upsert. looks like owners are never really removed, deleted field is just toggled.
…hen successful, change query upsert an owner invitation instead of inserting a crate_owner
modify publish message to describe error of publishing to a crate that you don't own with reference to invites
…_email_table and test_insert_into_email_table_with_change
…such that the owner invitation is accepted and user is added as an owner to the crate
…ation is accepted for the user to be added as an owner
|
I think you need to update your rustfmt version |
|
Yeah sorry about that @natboehm -- we updated rustfmt the other day. I wish there was a better way to notify each other when we do that... I have it set up locally so I just pushed a commit with rustfmt run with the newer version, let's see how that goes :) |
|
I also just resolved the merge conflict since it was due to that PR of mine that I mentioned wednesday, oops! |
|
Okay, it's fine, thanks for resolving all of that! |
|
Tested this out locally and it works great!! Thank you!! ❤️ ❤️ ❤️ ❤️ ❤️ bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Oct 6, 2017
1108: Require owner approval r=carols10cents This PR addresses issue #924, adding owners with their consent, deployable chunk 4. It implements the Crates functionality necessary for Cargo to invite a user to be an owner instead of automatically adding any user to be an owner of any crate. These changes correlate with the Cargo changes made in [this PR](rust-lang/cargo#4551). Function `owner_add` now creates an owner invitation instead of adding a user to be an owner, and returns a `boolean` okay value with a `String` message indicating that the user was invited to be an owner of the crate. This `boolean` okay value is not explicitly used for anything but is necessary to support older versions of Cargo, without which older versions will fail to decode only a `String` response.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #924, adding owners with their consent, deployable chunk 4. It implements the Crates functionality necessary for Cargo to invite a user to be an owner instead of automatically adding any user to be an owner of any crate. These changes correlate with the Cargo changes made in this PR. Function
owner_addnow creates an owner invitation instead of adding a user to be an owner, and returns abooleanokay value with aStringmessage indicating that the user was invited to be an owner of the crate. Thisbooleanokay value is not explicitly used for anything but is necessary to support older versions of Cargo, without which older versions will fail to decode only aStringresponse.