Accept owner invites #1073
Merged
Accept owner invites #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tements in a diesel transaction
…d invited_user_id
former version used two separate routes for accept and decline, now use one route but have boolean value sent back indicating if invite was accepted or declined
…and error messages on crate by crate basis
natboehm
force-pushed
the
accept-owner-invites
branch
from
4dec984 to
b64c808
Compare
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Sep 25, 2017
1073: Accept owner invites r=carols10cents This implements deployable chunk 2, accepting invitations of issue #924. I created a new route, `/me/crate_invitations/:crate_id` where a `PUT` request is submitted to. The request body contains the invitation information along with a boolean field `accepted`, indicating whether or not the invitation was accepted. This same route can then also be used for the decline route, a matter of toggling the `accepted` field. When an invitation is accepted, the user should receive a message where the invitation used to be acknowledging the successful addition. If an error occurs, a message should also appear indicating so.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements deployable chunk 2, accepting invitations of issue #924. I created a new route,
/me/crate_invitations/:crate_idwhere aPUTrequest is submitted to. The request body contains the invitation information along with a boolean fieldaccepted, indicating whether or not the invitation was accepted. This same route can then also be used for the decline route, a matter of toggling theacceptedfield. When an invitation is accepted, the user should receive a message where the invitation used to be acknowledging the successful addition. If an error occurs, a message should also appear indicating so.