Skip to content

403 forbidden on README. #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XAMPPRocky opened this issue Aug 19, 2017 · 3 comments
Closed

403 forbidden on README. #968

XAMPPRocky opened this issue Aug 19, 2017 · 3 comments
Labels
A-readme C-bug 🐞 Category: unintended, undesired behavior

Comments

@XAMPPRocky
Copy link
Member

tokei's README is getting a 403 forbidden.

@carols10cents
Copy link
Member

So because you have an include key in tokei's Cargo.toml and the value for include does not list README.md, the README isn't actually in the .crate archives. Do you not want your README in the .crate files purposefully?

I see that tokei's readme DOES show up on https://crates.io/crates/tokei now, because you've since published 6.1.0. cargo publish sends the readme separately from the .crate archive, and saves the latest received readme content in the database for use during searching. The readme rendering that happens on publishing is also using that.

However, we have a script that rerenders readmes that isn't looking in the database at all. So for example, tokei 6.1.0's readme has a table, and we changed markdown renderers to fix that, but the script to RErender readmes is only looking in the .crate archives for readmes, so it wasn't able to rerender tokei's and the old html wasn't replaced. That's definitely an enhancement we should make for the most recent version, at least. I filed #1019 for that.

To support crates that have a readme, a repository URL, and don't have the readme in the .crate archive, I suppose we could fall back further to request it from the repository?

@XAMPPRocky
Copy link
Member Author

XAMPPRocky commented Aug 27, 2017

@carols10cents I excluded the README.md since I had to add the include at one point as I was hitting the 10MB limit for a crate on https://crates.io, and since I don't think anyone can actually request the crate's source I didn't think it needed to be included.

@Turbo87
Copy link
Member

Turbo87 commented Oct 13, 2020

it looks like the root cause was identified here and since there wasn't much activity lately I'll go ahead and close this issue now

@Turbo87 Turbo87 closed this as completed Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-readme C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

No branches or pull requests

3 participants