Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render-readmes script should fall back to checking crate.readme in the database for the most recent version #1019

Open
carols10cents opened this issue Aug 27, 2017 · 0 comments
Open

Render-readmes script should fall back to checking crate.readme in the database for the most recent version #1019

carols10cents opened this issue Aug 27, 2017 · 0 comments
Labels
A-readme C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Comments

@carols10cents
Copy link
Member

There are some crates that have a readme specified in Cargo.toml, but exclude the README.md file from the archive (see #968). So render-readmes can't find the README.md in the .crate files from s3.

HOWEVER, we happen to have in the database the most recently published (which should probably be latest semvertically, see #953, #894) README.md that's used for searching. We could at least check that before giving up.
@carols10cents carols10cents mentioned this issue Aug 27, 2017
Closed
@carols10cents carols10cents added A-readme C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works labels Aug 28, 2017
@kivikakk kivikakk mentioned this issue Oct 17, 2017
Merged
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear and removed C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works labels Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-readme C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Turbo87 @carols10cents