Avoid inlining floor into rem_pio2
#982
Merged
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This passes the test suite (just needs a formatting fix), and with this change the |
quaternic
force-pushed
the
rem-pio2-avoid-floor
branch
from
dc83b57 to
4fecc36
Compare
quaternic
changed the title
floor in rem_pio2floor into rem_pio2
|
Clippy noise fixed in #995 |
quaternic
force-pushed
the
rem-pio2-avoid-floor
branch
from
4fecc36 to
7a44a13
Compare
quaternic
force-pushed
the
rem-pio2-avoid-floor
branch
from
7a44a13 to
8ea1de8
Compare
tgross35
approved these changes
Jul 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible workaround for #976 (comment)
Inline assembly in the body of a function currently causes the compiler to consider that function possibly unwinding, even if said asm originated from inlining an
extern "C"function. This patch wraps the problematic callsite with#[inline(never)].