WIP: wrote 3 tests about improving the error message in the path dependency #16138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…directory and invalid_manifest_in_path
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
epage
reviewed
Oct 22, 2025
| .file("crates/bar/src/lib.rs", "") | ||
| .build(); | ||
|
|
||
| p.cargo("check") |
There was a problem hiding this comment.
Suggested change
| p.cargo("check") | |
| p.cargo("generate-lockfile") |
Since these tests don't need building, this should make them run faster
epage
reviewed
Oct 22, 2025
Comment on lines
+1957
to
+1961
| error: no matching package named `definitely_not_bar` found at `bar/` | ||
| note: required by package `foo v0.1.0 (/Users/eric/Temp/foo)` | ||
| help: package `bar` exists at `bar/` | ||
| "#]]) |
There was a problem hiding this comment.
As a Draft, I appreciate showing your intent in shopping this around.
As you work on this, I'd recommend making the tests pass, showing the current behavior. Your next commit would then change Cargo's behavior and update the tests to show the new test output.
epage
reviewed
Oct 22, 2025
| ) | ||
| .run(); | ||
| } | ||
| // #[cargo_test] |
epage
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This PR is trying to improve the error message when the wrong package is found in the path dependency. Currently the PR started from the tests.
How to test and review this PR?
There are 3 tests added that cover each case that is brought up in this issue.
invalid_package_name_in_path()definitely_not_barexists in thecrates/barand it goes to thecrates/barto find that it is not present there and it gives the error.invalid_package_in_subdirectory()definitely_not_barexists in thecrates/barand after going there, it does not find it. Then it goes more deeper in thedefinitely_not_barto find that the manifest file exists there and give use the helpful message.invalid_manifest_in_path()definitely_not_barexists in thecrates/barbut after going there, it finds that there are other two packages butdefinitely_not_baris not present and it gives the message.