Expand token error messages with potential fix information. #15985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-registries
nathanhammond
force-pushed
the
authorization-scheme-error
branch
from
8d54a17 to
98df98b
Compare
|
Some notes on contributing:
|
| } else { | ||
| write!( | ||
| f, | ||
| "Your registry token is not prefixed with an embedded authorization scheme (e.g. `Bearer `).\n\ |
There was a problem hiding this comment.
🎉 This messaging would have saved me on the first hit :)
nathanhammond
force-pushed
the
authorization-scheme-error
branch
from
98df98b to
efe120c
Compare
nathanhammond
force-pushed
the
authorization-scheme-error
branch
from
efe120c to
5fcc082
Compare
nathanhammond
commented
Sep 24, 2025
| } | ||
| } | ||
|
|
||
| token_error_messages! { |
There was a problem hiding this comment.
@epage: since this whole PR is basically test cases followed by a tiny bit of string manipulation, would you mind taking an incremental look at just the test commit?
(the tests pass, auth_required on crates.io I've not yet attempted to discover if publish --workspace can support both crates.io and custom registries simultaneously. Regardless, I started with the cross-product to fully enumerate behavior.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two colleagues of mine spent a combined six hours yesterday trying to figure out why their custom registry was not working only to discover that it was due to the non-inclusion of
Beareras the authorization scheme in theAuthorizationheader.This PR is intended to present one possible path forward as a strawman for conversation in #15021.