Add workaround also for CURL 7.79.0. #15532
Conversation
rustbot
added
A-configuration
| @@ -3131,7 +3131,7 @@ fn disables_multiplexing_for_bad_curl( | |||
| use crate::util::network; | |||
|
|
|||
| if network::proxy::http_proxy_exists(http, gctx) && http.multiplexing.is_none() { | |||
| let bad_curl_versions = ["7.87.0", "7.88.0", "7.88.1"]; | |||
There was a problem hiding this comment.
Thanks for the fix!
Could you expand the commend a bit about what versions are bad on which platform?
And have we identified the root case about why 7.79.0 is bad? It would be ideal if it also mentioned in the comment like what we did for macOS.
There was a problem hiding this comment.
I don't have exact root cause. I can just guess that it's the same (proxy is involved). Latest Solaris CBE release 11.4.81 has newer CURL 8.12.0 and there are no problems. Sooner or later vmactions/solaris-vm will start to use it anyway...
There was a problem hiding this comment.
Does that version of Solaris build Cargo from scratch and not vendoring OpenSSL?
The official toolchain from rust-lang/rust, and the default dist build logic favors vendored-openssl. Also, why only 7.79.0, but not 7.80.0 or any other versions?
If Solaris image also vendored OpenSSL, then this might be a red herring.
I don't want to like blocking the workaround for a perfect investigation, though we also don't want to downgrade people's crate download experience. We've spent an amount of time on the topic to eventually came out with this workaroud. To be on the same standard we might want to dig into this one bit more. See the previous efforts:
- Cargo download dependency failed "send: no filter connected" #12202
- fix: disable multiplexing for some versions of curl #12234
- Zulip topic
Look around these linked issues, some other projects also replicate our fix. We might want to be a bit more cautious on this. Or the fix could be conditioned on Solaris, if that sounds right?
CURL 7.79.0 is bundled with Oracle Solaris 11.4.42 CBE release which is still used vi Github vmactions/solaris-vm. Fixes: rust-lang#15521
CURL 7.79.0 is bundled with Oracle Solaris 11.4.42 CBE release which is still used via Github vmactions/solaris-vm.
Fixes: #15521