-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fingerprint out of root targets #15205
base: master
Are you sure you want to change the base?
Conversation
r? @weihanglo rustbot has assigned @weihanglo. Use |
This is the hack described in #12266 (comment) and hence has the same caveats that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping with this issue!
As you've said, this is hacky. Some high-level feedback:
PathSource::list_file
(which then calls_list_files
) is used in computing fingerprints for build scripts andcargo doc
, as well as determining what is going to be packaged intocargo package
. During packaging, any file outside the package root will not be packed into the resulting.crate
file. Cargo even emits a warning when the situation is detected. With this change,cargo-package
starts including those files again. This is undesired, not even mention that where should their path be in the.crate
tarball.- How do this hack know what really needs to track? It simply looks at the directory the target source file is in and assume it always at the root directory with all other relevant files. Yeah it cannot handle
#[path]
we already knew, but it also doesn't respect git directory andinclude
/exclude
options. It may accidentally include more files they necessary.
To me I still think depinfo from rustdoc is a more sustainable approach. We might want to put more effort on that route than sorting out a hack.
Some other alternatives are on user side, like breaking them into sub packages for reasonable reuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- allow me to link rustdoc: add support for --emit=dep-info rust#91982 which is the tracking issue for the "sustainable" approach mentioned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It is linked in #12266 (comment), which also calls out a relevant Cargo issue #9931.
Also note that the issue is not labeled as |
This PR partially fixes #15203 and #12266 but this is admitedly a bit hackish, let me know how you want to proceed with it.